Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3375

Put client name in DataXceiver thread name for readBlock and keepalive

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.0.0-alpha
    • Component/s: datanode
    • Labels:
      None

      Description

      Currently the datanode thread names include the client for write operations, but not for read. We should include the client name for read ops. Additionally, in the keepalive phase, we should include the client name that initiated the previous request as well.

      1. hdfs-3375.txt
        3 kB
        Todd Lipcon

        Activity

        Todd Lipcon created issue -
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-3375.txt [ 12525704 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525704/hdfs-3375.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525704/hdfs-3375.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 2 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2381//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Todd Lipcon added a comment -

        Since this just changes thread names, no new unit tests. I did verify manually on a cluster with jstack output:

        • While uploading a file:

        "DataXceiver for client DFSClient_NONMAPREDUCE_-769101204_1 at /127.0.0.1:45087 [Receiving block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002]" daemon prio=10 tid=0x0000000040ff6000 nid=0x6215 runnable [0x00007fe5188c8000]

        • While downloading the same file

        "DataXceiver for client DFSClient_NONMAPREDUCE_-412315870_1 at /127.0.0.1:51891 [Sending block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002]" daemon prio=10 tid=0x0000000040bb8000 nid=0xa83 runnable [0x00007fe5188c9000]

        • During keepalive:
          "DataXceiver for client DFSClient_NONMAPREDUCE_-1536450876_1 at /127.0.0.1:51896 Waiting for operation #111" daemon prio=10 tid=0x00000000409a3000 nid=0x38f3 runnable [0x00007fe5188c9000]
        Show
        Todd Lipcon added a comment - Since this just changes thread names, no new unit tests. I did verify manually on a cluster with jstack output: While uploading a file: "DataXceiver for client DFSClient_NONMAPREDUCE_-769101204_1 at /127.0.0.1:45087 [Receiving block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002] " daemon prio=10 tid=0x0000000040ff6000 nid=0x6215 runnable [0x00007fe5188c8000] While downloading the same file "DataXceiver for client DFSClient_NONMAPREDUCE_-412315870_1 at /127.0.0.1:51891 [Sending block BP-1115842170-127.0.0.1-1336423035296:blk_1601307317176587197_1002] " daemon prio=10 tid=0x0000000040bb8000 nid=0xa83 runnable [0x00007fe5188c9000] During keepalive: "DataXceiver for client DFSClient_NONMAPREDUCE_-1536450876_1 at /127.0.0.1:51896 Waiting for operation #111 " daemon prio=10 tid=0x00000000409a3000 nid=0x38f3 runnable [0x00007fe5188c9000]
        Hide
        Todd Lipcon added a comment -

        Committed to 2.0 and trunk. Thanks for reviewing, Aaron.

        Show
        Todd Lipcon added a comment - Committed to 2.0 and trunk. Thanks for reviewing, Aaron.
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.0 [ 12320353 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #2276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2276/)
        HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2276/ ) HDFS-3375 . Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #2201 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2201/)
        HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2201 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2201/ ) HDFS-3375 . Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #2218 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2218/)
        HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

        Result = ABORTED
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2218 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2218/ ) HDFS-3375 . Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270) Result = ABORTED todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1038 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/)
        HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

        Result = FAILURE
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1038 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1038/ ) HDFS-3375 . Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/)
        HDFS-3375. Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270)

        Result = SUCCESS
        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1073 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1073/ ) HDFS-3375 . Put client name in DataXceiver thread name for readBlock and keepalive. Contributed by Todd Lipcon. (Revision 1335270) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1335270 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 58s 1 Todd Lipcon 05/May/12 01:07
        Patch Available Patch Available Resolved Resolved
        2d 21h 26m 1 Todd Lipcon 07/May/12 22:34

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development