Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14608

DataNode#DataTransfer should be named

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, the DataTransfer thread has no name and it just outputs the default toString().
      This shows in the logs in jstack as something like:

      2019-06-25 11:01:01,211 INFO [org.apache.hadoop.hdfs.server.datanode.DataNode$DataTransfer@609ed67a] org.apache.hadoop.hdfs.server.datanode.DataNode: DataTransfer, at CO4AEAP0000C1AF:10010: Transmitted BP-1191059133-10.1.2.3-1458888702348:blk_1113379522_69745835 (numBytes=485214) to 10.1.2.3/10.1.2.3:10010
      

      As this uses the Daemon class, the name is set based on:

        public Daemon(Runnable runnable) {
          super(runnable);
          this.runnable = runnable;
          this.setName(((Object)runnable).toString());
        }
      

      We should implement toString to at least have the name of the block being transfferred or something similar to what DataXceiver does (e.g., HDFS-3375).

        Attachments

        1. HDFS-14608.000.patch
          0.6 kB
          Íñigo Goiri
        2. HDFS-14608.001.patch
          0.7 kB
          Íñigo Goiri

          Issue Links

            Activity

              People

              • Assignee:
                elgoiri Íñigo Goiri
                Reporter:
                elgoiri Íñigo Goiri
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: