Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-3138

Move DatanodeInfo#ipcPort to DatanodeID

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      This change modifies DatanodeID, which is part of the client to server protocol, therefore clients must be upgraded with servers.

      Description

      We can fix the following TODO once HDFS-3137 is committed.

          //TODO: move it to DatanodeID once DatanodeID is not stored in FSImage
          out.writeShort(ipcPort);
      
      1. hdfs-3138.txt
        3 kB
        Eli Collins
      2. hdfs-3138.txt
        43 kB
        Eli Collins

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Link This issue depends on HDFS-3137 [ HDFS-3137 ]
          Hide
          Eli Collins added a comment -

          Patch attached. Includes the diff from HDFS-3139 so it will run against jenkins.

          Show
          Eli Collins added a comment - Patch attached. Includes the diff from HDFS-3139 so it will run against jenkins.
          Eli Collins made changes -
          Attachment hdfs-3138.txt [ 12519825 ]
          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Eli Collins made changes -
          Attachment hdfs-3138.txt [ 12520535 ]
          Hide
          Eli Collins added a comment -

          Filed HDFS-3164 to handle the hostname field since it's a more involved change.

          Show
          Eli Collins added a comment - Filed HDFS-3164 to handle the hostname field since it's a more involved change.
          Eli Collins made changes -
          Summary Move DatanodeInfo#ipcPort and hostName to DatanodeID Move DatanodeInfo#ipcPort to DatanodeID
          Description We can fix the following TODO once HDFS-3137 is committed. Also the hostName field should be moved as well (it's not ephemeral, just gets set on registration).

          {code}
              //TODO: move it to DatanodeID once DatanodeID is not stored in FSImage
              out.writeShort(ipcPort);
          {code}
          We can fix the following TODO once HDFS-3137 is committed.

          {code}
              //TODO: move it to DatanodeID once DatanodeID is not stored in FSImage
              out.writeShort(ipcPort);
          {code}
          Eli Collins made changes -
          Link This issue relates to HDFS-3164 [ HDFS-3164 ]
          Hide
          Aaron T. Myers added a comment -

          The change looks good to me. +1 pending Jenkins.

          Show
          Aaron T. Myers added a comment - The change looks good to me. +1 pending Jenkins.
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 0.23.3 [ 12320052 ] 2.0.0 [ 12320353 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12520535/hdfs-3138.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hdfs.TestHFlush

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2122//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2122//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520535/hdfs-3138.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestHFlush +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2122//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2122//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          The test failure is HDFS-3041. I've committed this and merged to branch-2. Thanks for the review ATM.

          Show
          Eli Collins added a comment - The test failure is HDFS-3041 . I've committed this and merged to branch-2. Thanks for the review ATM.
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ] Incompatible change,Reviewed [ 10342,10343 ]
          Release Note This change modifies DatanodeID, which is part of the client to server protocol, therefore clients must be upgraded with servers.
          Target Version/s 2.0.0 [ 12320353 ]
          Fix Version/s 2.0.0 [ 12320353 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2030 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2030/)
          HDFS-3138. Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2030 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2030/ ) HDFS-3138 . Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1955 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1955/)
          HDFS-3138. Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553)

          Result = SUCCESS
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1955 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1955/ ) HDFS-3138 . Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1968 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1968/)
          HDFS-3138. Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553)

          Result = ABORTED
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1968 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1968/ ) HDFS-3138 . Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1001 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1001/)
          HDFS-3138. Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1001 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1001/ ) HDFS-3138 . Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1036 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1036/)
          HDFS-3138. Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553)

          Result = FAILURE
          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1036 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1036/ ) HDFS-3138 . Move DatanodeInfo#ipcPort to DatanodeID. Contributed by Eli Collins (Revision 1307553) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307553 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
          Eli Collins made changes -
          Assignee Eli Collins [ eli2 ] Eli Collins [ eli ]
          Gavin made changes -
          Link This issue depends on HDFS-3137 [ HDFS-3137 ]
          Gavin made changes -
          Link This issue depends upon HDFS-3137 [ HDFS-3137 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development