Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: datanode, security
    • Labels:
    • Environment:
    • Target Version/s:

      Description

      If ssl is enabled (dfs.https.enable) but ssl-server.xml is not available, a DN will crash during startup while setting up an SSL socket with a NullPointerException:

      12/03/07 17:08:36 DEBUG security.Krb5AndCertsSslSocketConnector: useKerb = false, useCerts = true
      jetty.ssl.password : jetty.ssl.keypassword : 12/03/07 17:08:36 INFO mortbay.log: jetty-6.1.26.cloudera.1
      12/03/07 17:08:36 INFO mortbay.log: Started SelectChannelConnector@p-worker35.alley.sara.nl:1006
      12/03/07 17:08:36 DEBUG security.Krb5AndCertsSslSocketConnector: Creating new KrbServerSocket for: 0.0.0.0
      12/03/07 17:08:36 WARN mortbay.log: java.lang.NullPointerException
      12/03/07 17:08:36 WARN mortbay.log: failed Krb5AndCertsSslSocketConnector@0.0.0.0:50475: java.io.IOException: !JsseListener: java.lang.NullPointerException
      12/03/07 17:08:36 WARN mortbay.log: failed Server@604788d5: java.io.IOException: !JsseListener: java.lang.NullPointerException
      12/03/07 17:08:36 INFO mortbay.log: Stopped Krb5AndCertsSslSocketConnector@0.0.0.0:50475
      12/03/07 17:08:36 INFO mortbay.log: Stopped SelectChannelConnector@p-worker35.alley.sara.nl:1006
      12/03/07 17:08:37 INFO datanode.DataNode: Waiting for threadgroup to exit, active threads is 0

      The same happens if I set an absolute path to an existing dfs.https.server.keystore.resource - in this case the file cannot be found but not even a WARN is given.

      Since in dfs.https.server.keystore.resource we know we need to have 4 properties specified (ssl.server.truststore.location, ssl.server.keystore.location, ssl.server.keystore.password, and ssl.server.keystore.keypassword) we should check if they are set and throw an IOException if they are not.

      1. HDFS-3059.patch
        1.0 kB
        Evert Lammerts
      2. HDFS-3059.patch.2
        2 kB
        Evert Lammerts
      3. HDFS-3059.02.patch
        2 kB
        Allen Wittenauer
      4. HDFS-3059.03.patch
        2 kB
        Ravi Prakash
      5. HDFS-3059.04.patch
        6 kB
        Xiao Chen
      6. HDFS-3059.05.patch
        6 kB
        Xiao Chen
      7. HDFS-3059.06.patch
        6 kB
        Xiao Chen
      8. HDFS-3059.07.patch
        8 kB
        Xiao Chen
      9. HDFS-3059.08.patch
        9 kB
        Xiao Chen
      10. HDFS-3059-branch2.patch
        9 kB
        Xiao Chen

        Issue Links

          Activity

          Hide
          evertlammerts Evert Lammerts added a comment -

          This is a first attempt. If this is OK then it should be ported to 1.0 as well, and maybe other tags / versions.

          Show
          evertlammerts Evert Lammerts added a comment - This is a first attempt. If this is OK then it should be ported to 1.0 as well, and maybe other tags / versions.
          Hide
          atm Aaron T. Myers added a comment -

          Hey Evert, good find. The patch looks pretty good to me. I think it could be improved a little bit by having the error message include what actual config parameter(s) are missing from ssl-server.xml. Otherwise, users are still going to have to look at the code to figure out what they need to change. Do you agree?

          Also, you mention that this patch would need to be ported to 1.0 as well, but it looks to me like this patch isn't written against trunk. What version of Hadoop was it written for? In general, we require that all patches first be provided for trunk, and then be back-ported to maintenance branches like branch-1.0.

          Show
          atm Aaron T. Myers added a comment - Hey Evert, good find. The patch looks pretty good to me. I think it could be improved a little bit by having the error message include what actual config parameter(s) are missing from ssl-server.xml. Otherwise, users are still going to have to look at the code to figure out what they need to change. Do you agree? Also, you mention that this patch would need to be ported to 1.0 as well, but it looks to me like this patch isn't written against trunk. What version of Hadoop was it written for? In general, we require that all patches first be provided for trunk, and then be back-ported to maintenance branches like branch-1.0.
          Hide
          evertlammerts Evert Lammerts added a comment -

          Second try, with better feedback

          Show
          evertlammerts Evert Lammerts added a comment - Second try, with better feedback
          Hide
          evertlammerts Evert Lammerts added a comment -

          Second try, with better feedback

          Show
          evertlammerts Evert Lammerts added a comment - Second try, with better feedback
          Hide
          evertlammerts Evert Lammerts added a comment -

          Added better feedback, this should work. The first patch was written for tag 0.20.205 - I'm on CDH3u3 and was assuming 0.20.205 is the version it is based on.

          I have only tested it against CDH using the source RPMs, since I don't know how to set up a development environment for a DN in an environment with Kerberos enabled. Any tips about that are welcome, this was not a very comfortable way of debugging: editing the source, building it, copying the core jar to the datanode and namenode, and starting both; way to get RSI

          Show
          evertlammerts Evert Lammerts added a comment - Added better feedback, this should work. The first patch was written for tag 0.20.205 - I'm on CDH3u3 and was assuming 0.20.205 is the version it is based on. I have only tested it against CDH using the source RPMs, since I don't know how to set up a development environment for a DN in an environment with Kerberos enabled. Any tips about that are welcome, this was not a very comfortable way of debugging: editing the source, building it, copying the core jar to the datanode and namenode, and starting both; way to get RSI
          Hide
          evertlammerts Evert Lammerts added a comment -

          This one's against trunk, btw

          Show
          evertlammerts Evert Lammerts added a comment - This one's against trunk, btw
          Hide
          jingzhao Jing Zhao added a comment -

          I think this is a very useful feature. We just met the similar problem in both NN and DN when starting http server with https enabled. By applying the patch we can quickly identify the cause of the problem.

          Show
          jingzhao Jing Zhao added a comment - I think this is a very useful feature. We just met the similar problem in both NN and DN when starting http server with https enabled. By applying the patch we can quickly identify the cause of the problem.
          Hide
          raviprak Ravi Prakash added a comment -

          Patch doesn't apply on trunk anymore

          Show
          raviprak Ravi Prakash added a comment - Patch doesn't apply on trunk anymore
          Hide
          raviprak Ravi Prakash added a comment -

          Here's a patch but it doesn't throw an exception. I think we should throw an exception though

          Show
          raviprak Ravi Prakash added a comment - Here's a patch but it doesn't throw an exception. I think we should throw an exception though
          Hide
          xiaochen Xiao Chen added a comment -

          I have attached a patch 04 trying to fix the NullPointerException.

          • The initial patches looks great. Thanks for the contribution Evert, Aaron and Ravi!
          • Even if all configurations in ssl-server.xml are right, if the keystores were not setup/passed in correctly, we would still end up with the NPE. This is because DFSUtil#getPassword silently sets the password to null. I added a warn message here, because throwing exception seems to be too strict, and Java KeyStore allows passing null when load.
          • When starting secondarynamenode from shell with security enabled, it unnecessarily checks for password and try to setup a web server, which then may end up in the same NPE. I checked for whether it's called from shell before firing up the web server.

          I have only tested this manually, don't think unit testing is needed as this is more of a supportability issue.

          Show
          xiaochen Xiao Chen added a comment - I have attached a patch 04 trying to fix the NullPointerException. The initial patches looks great. Thanks for the contribution Evert, Aaron and Ravi! Even if all configurations in ssl-server.xml are right, if the keystores were not setup/passed in correctly, we would still end up with the NPE. This is because DFSUtil#getPassword silently sets the password to null. I added a warn message here, because throwing exception seems to be too strict, and Java KeyStore allows passing null when load. When starting secondarynamenode from shell with security enabled, it unnecessarily checks for password and try to setup a web server, which then may end up in the same NPE. I checked for whether it's called from shell before firing up the web server. I have only tested this manually, don't think unit testing is needed as this is more of a supportability issue.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 20s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 9m 6s There were no new javac warning messages.
          +1 javadoc 11m 43s There were no new javadoc warning messages.
          -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
          -1 checkstyle 1m 40s The applied patch generated 5 new checkstyle issues (total was 506, now 511).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 findbugs 2m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 39s Pre-build of native portion
          -1 hdfs tests 199m 4s Tests failed in hadoop-hdfs.
              250m 56s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestWriteRead
            hadoop.hdfs.server.blockmanagement.TestNodeCount
            hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765719/HDFS-3059.04.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b4390d5
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12877/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12877/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 6s There were no new javac warning messages. +1 javadoc 11m 43s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. -1 checkstyle 1m 40s The applied patch generated 5 new checkstyle issues (total was 506, now 511). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 2m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 39s Pre-build of native portion -1 hdfs tests 199m 4s Tests failed in hadoop-hdfs.     250m 56s   Reason Tests Failed unit tests hadoop.hdfs.TestWriteRead   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765719/HDFS-3059.04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b4390d5 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12877/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12877/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12877/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          The test failures/release audit warnings are unrelated, and as described above no test is needed.

          Updated patch 05 to address the checkstyle issue: since I touched SecondaryNameNode, I think it makes sense to make the changed part within 80 chars. DFSConfigKeys seems to be not following the 80 chars rule, so kept my original code.

          Would someone please help review? Thanks in advance.

          Show
          xiaochen Xiao Chen added a comment - The test failures/release audit warnings are unrelated, and as described above no test is needed. Updated patch 05 to address the checkstyle issue: since I touched SecondaryNameNode , I think it makes sense to make the changed part within 80 chars. DFSConfigKeys seems to be not following the 80 chars rule, so kept my original code. Would someone please help review? Thanks in advance.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 20m 0s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 9m 4s There were no new javac warning messages.
          +1 javadoc 11m 32s There were no new javadoc warning messages.
          -1 release audit 0m 22s The applied patch generated 1 release audit warnings.
          -1 checkstyle 1m 7s The applied patch generated 508 new checkstyle issues (total was 0, now 508).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 30s Pre-build of native portion
          -1 hdfs tests 195m 18s Tests failed in hadoop-hdfs.
              245m 53s  



          Reason Tests
          Failed unit tests hadoop.hdfs.util.TestByteArrayManager
          Timed out tests org.apache.hadoop.hdfs.TestHDFSFileSystemContract



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765887/HDFS-3059.05.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 4f6e842
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12900/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12900/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 20m 0s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 4s There were no new javac warning messages. +1 javadoc 11m 32s There were no new javadoc warning messages. -1 release audit 0m 22s The applied patch generated 1 release audit warnings. -1 checkstyle 1m 7s The applied patch generated 508 new checkstyle issues (total was 0, now 508). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 44s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 30s Pre-build of native portion -1 hdfs tests 195m 18s Tests failed in hadoop-hdfs.     245m 53s   Reason Tests Failed unit tests hadoop.hdfs.util.TestByteArrayManager Timed out tests org.apache.hadoop.hdfs.TestHDFSFileSystemContract Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765887/HDFS-3059.05.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4f6e842 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12900/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12900/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12900/console This message was automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Xiao Chen,

          Thanks for working on this issue. I browsed it and have some comments/question:

               LOG.warn("IOException caught when getting password, setting password "
                    + "to null. Exception:\"" + ioe.getMessage() + "\".");
          

          to:

               LOG.warn("Setting password to null since IOException is caught when getting password", ioe);
          

          2. Add comma to " is specified make sure it is a relative path" as "is specified, make sure it is a relative path"

          3. Would you please explain why the following comments? maybe add the explanation as an addition to the comment.

             // This is only needed when starting SNN as a daemon,
             // and no need to run it if called from shell command.
          

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - HI Xiao Chen , Thanks for working on this issue. I browsed it and have some comments/question: LOG.warn( "IOException caught when getting password, setting password " + "to null . Exception:\" " + ioe.getMessage() + " \ "." ); to: LOG.warn( "Setting password to null since IOException is caught when getting password" , ioe); 2. Add comma to " is specified make sure it is a relative path" as "is specified, make sure it is a relative path" 3. Would you please explain why the following comments? maybe add the explanation as an addition to the comment. // This is only needed when starting SNN as a daemon, // and no need to run it if called from shell command. Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Yongjun for the comments. Attached patch 06 addressed your suggestions.

          3. Would you please explain why the following comments? maybe add the explanation as an addition to the comment.

          This is added because I met the same NPE described when running secondarynamenode (2NN). Running a command like hdfs secondarynamenode -checkpoint with kerberos enabled will fail with the same NPE thrown. The cause is that 2NN web server is needed when starting as a daemon, to show status/metrics etc., which needs to get credentials. When running from shell, the environment doesn't have the credentials and prompts for password. When the password is not correct, getPassword sets the password to null, causing the NPE. Note that clients are't supposed to know the password, but we should definitely allow them to checkpoint. Since the metrics etc. are not needed when running 2NN from shell, I think it makes sense to not start the web server at all.
          I have updated the comments like below, to give more information.

            // The web server is only needed when starting SNN as a daemon,
            // and not needed if called from shell command. Starting the web server
            // from shell may fail when getting credentials, if the environment is not
            // set up for it, which is most of the case.
          
          Show
          xiaochen Xiao Chen added a comment - Thanks Yongjun for the comments. Attached patch 06 addressed your suggestions. 3. Would you please explain why the following comments? maybe add the explanation as an addition to the comment. This is added because I met the same NPE described when running secondarynamenode (2NN). Running a command like hdfs secondarynamenode -checkpoint with kerberos enabled will fail with the same NPE thrown. The cause is that 2NN web server is needed when starting as a daemon, to show status/metrics etc., which needs to get credentials. When running from shell, the environment doesn't have the credentials and prompts for password. When the password is not correct, getPassword sets the password to null, causing the NPE. Note that clients are't supposed to know the password, but we should definitely allow them to checkpoint. Since the metrics etc. are not needed when running 2NN from shell, I think it makes sense to not start the web server at all. I have updated the comments like below, to give more information. // The web server is only needed when starting SNN as a daemon, // and not needed if called from shell command. Starting the web server // from shell may fail when getting credentials, if the environment is not // set up for it, which is most of the case .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 21m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 35s There were no new javac warning messages.
          +1 javadoc 11m 10s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 30s The applied patch generated 2 new checkstyle issues (total was 508, now 510).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 39s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 2m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 25s Pre-build of native portion
          -1 hdfs tests 62m 57s Tests failed in hadoop-hdfs.
              114m 18s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766944/HDFS-3059.06.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0ab3f9d
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13044/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13044/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 21m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 35s There were no new javac warning messages. +1 javadoc 11m 10s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 30s The applied patch generated 2 new checkstyle issues (total was 508, now 510). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 39s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 25s Pre-build of native portion -1 hdfs tests 62m 57s Tests failed in hadoop-hdfs.     114m 18s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766944/HDFS-3059.06.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0ab3f9d Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13044/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13044/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13044/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Xiao, code-wise looks functionally good, only stylistic comments:

          • I'm not a fan of this conditional behavior buried in initialize; how do you feel about moving starting infoServer to a new function, and calling it before we do startCheckpointThread in main? This makes this behavior difference more explicit.
          • The new DFSConfigKeys constants should end in _KEY like the other variables in this file.
          Show
          andrew.wang Andrew Wang added a comment - Hi Xiao, code-wise looks functionally good, only stylistic comments: I'm not a fan of this conditional behavior buried in initialize ; how do you feel about moving starting infoServer to a new function, and calling it before we do startCheckpointThread in main? This makes this behavior difference more explicit. The new DFSConfigKeys constants should end in _KEY like the other variables in this file.
          Hide
          xiaochen Xiao Chen added a comment -

          Hi Andrew,
          Thanks a lot for the review.

          I'm not a fan of this conditional behavior buried in initialize; how do you feel about moving starting infoServer to a new function, and calling it before we do startCheckpointThread in main? This makes this behavior difference more explicit.

          Great idea! Fixed. I think this should be the way to go - it's more straightforward, and we can save the nullity check for ops in main.

          The new DFSConfigKeys constants should end in _KEY like the other variables in this file.

          Good catch. Fixed.

          Patch 07 was uploaded.

          Show
          xiaochen Xiao Chen added a comment - Hi Andrew, Thanks a lot for the review. I'm not a fan of this conditional behavior buried in initialize; how do you feel about moving starting infoServer to a new function, and calling it before we do startCheckpointThread in main? This makes this behavior difference more explicit. Great idea! Fixed. I think this should be the way to go - it's more straightforward, and we can save the nullity check for ops in main. The new DFSConfigKeys constants should end in _KEY like the other variables in this file. Good catch. Fixed. Patch 07 was uploaded.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 18m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 29s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 26s The applied patch generated 2 new checkstyle issues (total was 508, now 509).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 21s Pre-build of native portion
          -1 hdfs tests 49m 55s Tests failed in hadoop-hdfs.
              96m 33s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestHDFSServerPorts



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767510/HDFS-3059.07.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ded012e
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13067/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13067/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 17s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 29s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 26s The applied patch generated 2 new checkstyle issues (total was 508, now 509). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 21s Pre-build of native portion -1 hdfs tests 49m 55s Tests failed in hadoop-hdfs.     96m 33s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestHDFSServerPorts Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767510/HDFS-3059.07.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ded012e Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13067/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13067/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13067/console This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Patch 08 fixed the test failure.

          Show
          xiaochen Xiao Chen added a comment - Patch 08 fixed the test failure.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 18m 20s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 10m 21s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 24s The applied patch generated 2 new checkstyle issues (total was 508, now 509).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 7s Pre-build of native portion
          -1 hdfs tests 49m 48s Tests failed in hadoop-hdfs.
              95m 49s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestDNFencing



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767547/HDFS-3059.08.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 9cb5d35
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13076/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13076/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 20s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 21s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 24s The applied patch generated 2 new checkstyle issues (total was 508, now 509). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 7s Pre-build of native portion -1 hdfs tests 49m 48s Tests failed in hadoop-hdfs.     95m 49s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestDNFencing Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767547/HDFS-3059.08.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 9cb5d35 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13076/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13076/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13076/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM +1 will commit shortly, I ran the failed test locally okay.

          Show
          andrew.wang Andrew Wang added a comment - LGTM +1 will commit shortly, I ran the failed test locally okay.
          Hide
          andrew.wang Andrew Wang added a comment -

          Committed to trunk, branch-2 wasn't clean. Xiao, mind preparing a branch-2 patch as well?

          Show
          andrew.wang Andrew Wang added a comment - Committed to trunk, branch-2 wasn't clean. Xiao, mind preparing a branch-2 patch as well?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8672/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8672/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/559/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #559 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/559/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/574/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #574 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/574/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1294/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1294/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #519 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/519/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #519 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/519/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2507 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2507/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2507 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2507/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          Hide
          xiaochen Xiao Chen added a comment -

          Hi Andrew Wang, I've attached the patch based on branch-2. Thanks again!

          Show
          xiaochen Xiao Chen added a comment - Hi Andrew Wang , I've attached the patch based on branch-2. Thanks again!
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM, thanks Xiao, committed to branch-2

          Show
          andrew.wang Andrew Wang added a comment - LGTM, thanks Xiao, committed to branch-2
          Hide
          xiaochen Xiao Chen added a comment -

          Thank you Andrew!

          Show
          xiaochen Xiao Chen added a comment - Thank you Andrew!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2456/)
          HDFS-3059. ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2456 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2456/ ) HDFS-3059 . ssl-server.xml causes NullPointer. Contributed by Xiao Chen. (wang: rev 6c8b6f3646b31a3e028704bc7fd78bf319f89f0a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSServerPorts.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java

            People

            • Assignee:
              xiaochen Xiao Chen
              Reporter:
              evertlammerts Evert Lammerts
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development