Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
Two nits:
- The checking whether secondary is null is not necessary in the following code in SecondaryNameNode.java.
- The comment in this code seems to imply that "when secondary is not null, SNN was stared as a daemon.", and this is not true. Suggest to improve the comment to make it clear,
Assign to Xiao since he worked on HDFS-3059. Thanks Xiao.
if (secondary != null) { // The web server is only needed when starting SNN as a daemon, // and not needed if called from shell command. Starting the web server // from shell may fail when getting credentials, if the environment // is not set up for it, which is most of the case. secondary.startInfoServer(); secondary.startCheckpointThread(); secondary.join(); }
Attachments
Attachments
Issue Links
- relates to
-
HDFS-3059 ssl-server.xml causes NullPointer
- Resolved