Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2889

getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.24.0, 0.23.1
    • Component/s: hdfs-client
    • Labels:
      None

      Description

      See https://issues.apache.org/jira/browse/HDFS-2408
      HDFS-2408 was not committed to 0.23 (or trunk it looks like).

      This is breaking HBase unit tests with "-Dhadoop.profile=23"

      1. HDFS-2889.patch
        0.8 kB
        Gregory Chanan

        Activity

        Hide
        Aaron T. Myers added a comment -

        Marking patch available for Greg so test-patch runs.

        Show
        Aaron T. Myers added a comment - Marking patch available for Greg so test-patch runs.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12513172/HDFS-2889.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1839//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1839//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12513172/HDFS-2889.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1839//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1839//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. No tests are required since it's just changing the visibility of a method.

        I'll commit this shortly unless there are any comments from anyone.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. No tests are required since it's just changing the visibility of a method. I'll commit this shortly unless there are any comments from anyone.
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and the 0.23 branch. Thanks a lot for the contribution, Greg!

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and the 0.23 branch. Thanks a lot for the contribution, Greg!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #482 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/482/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #482 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/482/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1655 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1655/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1655 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1655/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1726/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1726/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #472 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/472/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #472 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/472/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/495/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/495/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1670 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1670/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1670 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1670/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #946 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/946/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #946 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/946/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #159 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/159/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #159 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/159/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/181/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/181/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #979 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/979/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #979 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/979/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java

          People

          • Assignee:
            Gregory Chanan
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development