Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2408

DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 0.20.205.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The below commit broke hdfs-826 for hbase in 205 rc1. It changes the accessiblity from public to package private on getNumCurrentReplicas and now current shipping hbase's at least cannot get at this method.

      Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
      Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
      File length: 136876 byte(s) 
      Diff to previous 1174479 (colored)
      svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
      

      Here is diff between above change and one just previous:

      http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diff&r1=1174479&r2=1174483&diff_format=u

      This is a critical facility for us.

      It seems like making this one method public again is all thats needed. I can make a patch like the below:

      diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
      index b9cb053..39955c9 100644
      — a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
      +++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
      @@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, java.io.Closeable {

      • block is not yet allocated, then this API will return 0 because there are
      • no replicas in the pipeline.
        */
      • int getNumCurrentReplicas() throws IOException {
        + public int getNumCurrentReplicas() throws IOException {
        synchronized(dataQueue) {
        if (nodes == null) {
        return blockReplication;

      Can we get this into RC2?

      Thanks,
      St.Ack

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #979 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/979/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #979 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/979/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/181/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/181/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #159 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/159/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #159 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/159/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #946 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/946/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #946 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/946/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1670 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1670/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1670 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1670/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/495/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/495/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #472 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/472/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #472 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/472/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1726/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1726 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1726/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1655 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1655/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1655 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1655/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240412 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #482 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/482/)
        HDFS-2889. getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408). Contributed by Gregory Chanan.

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #482 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/482/ ) HDFS-2889 . getNumCurrentReplicas is package private but should be public on 0.23 (see HDFS-2408 ). Contributed by Gregory Chanan. atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1240415 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
        Hide
        Aaron T. Myers added a comment -

        Can we do the same thing for 0.23 and trunk? I'm happy to open a new JIRA and submit a patch.

        I see no reason we can't do the same for 0.23 and trunk. Please file a new JIRA/post a patch and I'll be happy to take a look at it ASAP.

        Show
        Aaron T. Myers added a comment - Can we do the same thing for 0.23 and trunk? I'm happy to open a new JIRA and submit a patch. I see no reason we can't do the same for 0.23 and trunk. Please file a new JIRA/post a patch and I'll be happy to take a look at it ASAP.
        Hide
        Gregory Chanan added a comment -

        Can we do the same thing for 0.23 and trunk? I'm happy to open a new JIRA and submit a patch.

        Show
        Gregory Chanan added a comment - Can we do the same thing for 0.23 and trunk? I'm happy to open a new JIRA and submit a patch.
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Hide
        Matt Foley added a comment -

        Thanks, stack, for the good catch, and aaron thanks for the fast review. This will go in 0.20.205.0-rc2.

        Show
        Matt Foley added a comment - Thanks, stack, for the good catch, and aaron thanks for the fast review. This will go in 0.20.205.0-rc2.
        Hide
        Aaron T. Myers added a comment -

        Thanks Suresh. I've just committed this to branch-0.20-security and branch-0.20-security-205.

        Show
        Aaron T. Myers added a comment - Thanks Suresh. I've just committed this to branch-0.20-security and branch-0.20-security-205.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12497951/hdfs-2408.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1343//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12497951/hdfs-2408.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1343//console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        Can you please commit this at the earlier. I can do that if you are busy. This will help get rc2 out sooner.

        Show
        Suresh Srinivas added a comment - Can you please commit this at the earlier. I can do that if you are busy. This will help get rc2 out sooner.
        Hide
        Suresh Srinivas added a comment -

        Aaron, this is 205 patch. Are you starting Jenkins pre-commit build?

        Show
        Suresh Srinivas added a comment - Aaron, this is 205 patch. Are you starting Jenkins pre-commit build?
        Hide
        Aaron T. Myers added a comment -

        D'oh! I forgot that Jenkins isn't going to be able to apply the patch since the patch is for 0.20-security.

        Regardless, the patch is trivial. I'll commit it tomorrow unless there are any objections in the mean time.

        Show
        Aaron T. Myers added a comment - D'oh! I forgot that Jenkins isn't going to be able to apply the patch since the patch is for 0.20-security. Regardless, the patch is trivial. I'll commit it tomorrow unless there are any objections in the mean time.
        Hide
        Aaron T. Myers added a comment -

        The patch looks good to me. Marking as patch available on Stack's behalf so Jenkins gives it a spin.

        +1 pending clean Jenkins results.

        Show
        Aaron T. Myers added a comment - The patch looks good to me. Marking as patch available on Stack's behalf so Jenkins gives it a spin. +1 pending clean Jenkins results.
        Hide
        stack added a comment -

        Change getNumCurrentReplicas back to public again.

        Show
        stack added a comment - Change getNumCurrentReplicas back to public again.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development