Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-2654

Make BlockReaderLocal not extend RemoteBlockReader2

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.23.1, 1.0.0
    • 0.23.1, 1.1.0
    • datanode
    • None
    • Reviewed

    Description

      The BlockReaderLocal code paths are easier to understand (especially true on branch-1 where BlockReaderLocal inherits code from BlockerReader and FSInputChecker) if the local and remote block reader implementations are independent, and they're not really sharing much code anyway. If for some reason they start to share significant code we can make the BlockReader interface an abstract class.

      Attachments

        1. hdfs-2654-1.patch
          6 kB
          Eli Collins
        2. hdfs-2654-2.patch
          10 kB
          Eli Collins
        3. hdfs-2654-2.patch
          10 kB
          Eli Collins
        4. hdfs-2654-2.patch
          10 kB
          Eli Collins
        5. hdfs-2654-3.patch
          10 kB
          Eli Collins
        6. hdfs-2654-b1-1.patch
          11 kB
          Eli Collins
        7. hdfs-2654-b1-2.patch
          13 kB
          Eli Collins
        8. hdfs-2654-b1-3.patch
          21 kB
          Eli Collins
        9. hdfs-2654-b1-4.patch
          22 kB
          Eli Collins
        10. hdfs-2654-b1-4-fix.patch
          0.5 kB
          Eli Collins

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. HDFS-2246 Shortcut a local client reads to a Datanodes files directly

          • Major - Major loss of function.
          • Closed

          Activity

            People

              eli Eli Collins
              eli Eli Collins
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: