Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2654

Make BlockReaderLocal not extend RemoteBlockReader2

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 1.0.0
    • Fix Version/s: 0.23.1, 1.1.0
    • Component/s: datanode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The BlockReaderLocal code paths are easier to understand (especially true on branch-1 where BlockReaderLocal inherits code from BlockerReader and FSInputChecker) if the local and remote block reader implementations are independent, and they're not really sharing much code anyway. If for some reason they start to share significant code we can make the BlockReader interface an abstract class.

      1. hdfs-2654-1.patch
        6 kB
        Eli Collins
      2. hdfs-2654-2.patch
        10 kB
        Eli Collins
      3. hdfs-2654-2.patch
        10 kB
        Eli Collins
      4. hdfs-2654-2.patch
        10 kB
        Eli Collins
      5. hdfs-2654-3.patch
        10 kB
        Eli Collins
      6. hdfs-2654-b1-1.patch
        11 kB
        Eli Collins
      7. hdfs-2654-b1-2.patch
        13 kB
        Eli Collins
      8. hdfs-2654-b1-3.patch
        21 kB
        Eli Collins
      9. hdfs-2654-b1-4.patch
        22 kB
        Eli Collins
      10. hdfs-2654-b1-4-fix.patch
        0.5 kB
        Eli Collins

        Issue Links

          Activity

          Eli Collins created issue -
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-2654-1.patch [ 12506824 ]
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
          Eli Collins made changes -
          Attachment hdfs-2654-b1-1.patch [ 12506828 ]
          Eli Collins made changes -
          Link This issue is related to HDFS-2246 [ HDFS-2246 ]
          Eli Collins made changes -
          Attachment hdfs-2654-2.patch [ 12506831 ]
          Eli Collins made changes -
          Attachment hdfs-2654-2.patch [ 12506832 ]
          Eli Collins made changes -
          Attachment hdfs-2654-b1-2.patch [ 12506834 ]
          Eli Collins made changes -
          Attachment hdfs-2654-2.patch [ 12506858 ]
          Eli Collins made changes -
          Attachment hdfs-2654-b1-3.patch [ 12506862 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
          Eli Collins made changes -
          Attachment hdfs-2654-3.patch [ 12507146 ]
          Eli Collins made changes -
          Attachment hdfs-2654-b1-4.patch [ 12507149 ]
          Eli Collins made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
          Resolution Fixed [ 1 ]
          Eli Collins made changes -
          Attachment hdfs-2654-b1-4-fix.patch [ 12507810 ]
          Ted Yu made changes -
          Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
          Description The BlockReaderLocal code paths are easier to understand (especially true on branch-1 where BlockReaderLocal inherits code from BlockerReader and FSInputChecker) if the local and remote block reader implementations are independent, and they're not really sharing much code anyway. If for some reason they start to share sifnificant code we can make the BlockReader interface an abstract class. The BlockReaderLocal code paths are easier to understand (especially true on branch-1 where BlockReaderLocal inherits code from BlockerReader and FSInputChecker) if the local and remote block reader implementations are independent, and they're not really sharing much code anyway. If for some reason they start to share significant code we can make the BlockReader interface an abstract class.
          Suresh Srinivas made changes -
          Fix Version/s 0.24.0 [ 12317653 ]
          Fix Version/s 0.23.1 [ 12318885 ]
          Target Version/s 1.1.0, 0.23.1 [ 12317959, 12318885 ] 0.23.1, 1.1.0 [ 12318885, 12317959 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Matt Foley made changes -
          Fix Version/s 1.1.0 [ 12317959 ]
          Target Version/s 0.23.1, 1.1.0 [ 12318885, 12317959 ] 0.23.1, 0.24.0, 1.1.0 [ 12318885, 12317653, 12317959 ]
          Allen Wittenauer made changes -
          Fix Version/s 0.24.0 [ 12317653 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development