Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2337

DFSClient shouldn't keep multiple RPC proxy references

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: hdfs-client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      With the commit of HADOOP-7635, RetryInvocationHandler objects will clean up the underlying InvocationHandler objects they reference. We should change DFSClient to take advantage of this fact.

      1. hdfs-2337.patch
        2 kB
        Aaron T. Myers

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to 0.23.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
        Hide
        Eli Collins added a comment -

        Good candidate for merging to branch 23.

        Show
        Eli Collins added a comment - Good candidate for merging to branch 23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/)
        HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/833/ ) HDFS-2337 . DFSClient shouldn't keep multiple RPC proxy references (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/)
        HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/803/ ) HDFS-2337 . DFSClient shouldn't keep multiple RPC proxy references (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #915 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/915/)
        HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #915 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/915/ ) HDFS-2337 . DFSClient shouldn't keep multiple RPC proxy references (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #977 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/977/)
        HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #977 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/977/ ) HDFS-2337 . DFSClient shouldn't keep multiple RPC proxy references (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #900 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/900/)
        HDFS-2337. DFSClient shouldn't keep multiple RPC proxy references (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #900 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/900/ ) HDFS-2337 . DFSClient shouldn't keep multiple RPC proxy references (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171711 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Aaron T. Myers added a comment -

        I've just committed this.

        Show
        Aaron T. Myers added a comment - I've just committed this.
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Eli. I will commit this in an hour or so unless there are more comments in the mean time.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Eli. I will commit this in an hour or so unless there are more comments in the mean time.
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1
        Hide
        Aaron T. Myers added a comment -

        No tests are included since this is basically just a refactor. The fact that underlying resources are closed when a RetryInvocationHandler which wraps another InvocationHandler is closed was tested in HADOOP-7635.

        The failing tests are unrelated.

        Show
        Aaron T. Myers added a comment - No tests are included since this is basically just a refactor. The fact that underlying resources are closed when a RetryInvocationHandler which wraps another InvocationHandler is closed was tested in HADOOP-7635 . The failing tests are unrelated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494712/hdfs-2337.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestDfsOverAvroRpc
        org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1256//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1256//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494712/hdfs-2337.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDfsOverAvroRpc org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1256//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1256//console This message is automatically generated.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development