Hadoop Common
  1. Hadoop Common
  2. HADOOP-7635

RetryInvocationHandler should release underlying resources on close

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It is often the case that RPC invocation handlers (e.g. o.a.h.ipc.WritableRpcEngine.Invoker) are wrapped in a RetryInvocationHandler instance to handle RPC retry logic. Since RetryInvocationHandler doesn't have any resources of its own, and is incapable of releasing the resources of the wrapped InvocationHandler, users of RetryInvocationHandler must keep around a reference to the underlying InvocationHandler only for the purpose of closing. For an example of this, see o.a.h.hdfs.DFSClient, in particular the member variables namenode and rpcNamenode.

      1. hadoop-7635.0.txt
        15 kB
        Aaron T. Myers
      2. hadoop-7635.1.txt
        12 kB
        Aaron T. Myers

        Activity

        Aaron T. Myers created issue -
        Aaron T. Myers made changes -
        Field Original Value New Value
        Attachment hadoop-7635.0.txt [ 12494535 ]
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Aaron T. Myers made changes -
        Attachment hadoop-7635.1.txt [ 12494572 ]
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Aaron T. Myers made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Eli Collins made changes -
        Target Version/s 0.23.1 [ 12318884 ]
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s 0.23.3 [ 12320059 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development