Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7635

RetryInvocationHandler should release underlying resources on close

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.24.0
    • 2.0.0-alpha
    • ipc
    • None
    • Reviewed

    Description

      It is often the case that RPC invocation handlers (e.g. o.a.h.ipc.WritableRpcEngine.Invoker) are wrapped in a RetryInvocationHandler instance to handle RPC retry logic. Since RetryInvocationHandler doesn't have any resources of its own, and is incapable of releasing the resources of the wrapped InvocationHandler, users of RetryInvocationHandler must keep around a reference to the underlying InvocationHandler only for the purpose of closing. For an example of this, see o.a.h.hdfs.DFSClient, in particular the member variables namenode and rpcNamenode.

      Attachments

        1. hadoop-7635.1.txt
          12 kB
          Aaron Myers
        2. hadoop-7635.0.txt
          15 kB
          Aaron Myers

        Activity

          People

            atm Aaron Myers
            atm Aaron Myers
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: