Hadoop Common
  1. Hadoop Common
  2. HADOOP-7635

RetryInvocationHandler should release underlying resources on close

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      It is often the case that RPC invocation handlers (e.g. o.a.h.ipc.WritableRpcEngine.Invoker) are wrapped in a RetryInvocationHandler instance to handle RPC retry logic. Since RetryInvocationHandler doesn't have any resources of its own, and is incapable of releasing the resources of the wrapped InvocationHandler, users of RetryInvocationHandler must keep around a reference to the underlying InvocationHandler only for the purpose of closing. For an example of this, see o.a.h.hdfs.DFSClient, in particular the member variables namenode and rpcNamenode.

      1. hadoop-7635.1.txt
        12 kB
        Aaron T. Myers
      2. hadoop-7635.0.txt
        15 kB
        Aaron T. Myers

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development