Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      FindBugs 1.3.9, ant 1.8.2, RHEL6, Jenkins 1.414 in Tomcat 7.0.14, Sun Java HotSpot(TM) 64-Bit Server VM

    • Hadoop Flags:
      Reviewed

      Description

      When running the findbugs target from Jenkins, I get an OutOfMemory error.
      The "effort" in FindBugs is set to Max which ends up using a lot of memory to go through all the classes. The jvmargs passed to FindBugs is hardcoded to 512 MB max.

      We can leave the default to 512M, as long as we pass this as an ant parameter which can be overwritten in individual cases through -D, or in the build.properties file (either basedir, or user's home directory).

      1. HDFS-2297.patch
        1 kB
        Joep Rottinghuis

        Issue Links

          Activity

          Hide
          Joep Rottinghuis added a comment -

          findbugs:
          [mkdir] Created dir: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/test/findbugs
          [findbugs] Executing findbugs from ant task
          [findbugs] Running FindBugs...
          [findbugs] Out of memory
          [findbugs] Total memory: 477M
          [findbugs] free memory: 65M
          [findbugs] Analyzed: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/hadoop-hdfs-0.22-joep-0.1.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/ant-1.6.5.jar
          ...lines cut
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/paranamer-ant-2.2.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/paranamer-generator-2.2.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/qdox-1.10.1.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/servlet-api-2.5-6.1.14.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/slf4j-api-1.5.11.jar
          [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/xmlenc-0.52.jar
          [findbugs] Exception in thread "main" java.lang.OutOfMemoryError: GC overhead limit exceeded
          [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.createFact(TypeAnalysis.java:291)
          [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.getCachedExceptionSet(TypeAnalysis.java:688)
          [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.computeThrownExceptionTypes(TypeAnalysis.java:438)
          [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.transfer(TypeAnalysis.java:410)
          [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.transfer(TypeAnalysis.java:88)
          [findbugs] at edu.umd.cs.findbugs.ba.Dataflow.execute(Dataflow.java:356)
          [findbugs] at edu.umd.cs.findbugs.classfile.engine.bcel.TypeDataflowFactory.analyze(TypeDataflowFactory.java:82)
          ... 27 more
          [findbugs] Java Result: 1

          Show
          Joep Rottinghuis added a comment - findbugs: [mkdir] Created dir: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/test/findbugs [findbugs] Executing findbugs from ant task [findbugs] Running FindBugs... [findbugs] Out of memory [findbugs] Total memory: 477M [findbugs] free memory: 65M [findbugs] Analyzed: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/hadoop-hdfs-0.22-joep-0.1.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/ant-1.6.5.jar ...lines cut [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/paranamer-ant-2.2.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/paranamer-generator-2.2.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/qdox-1.10.1.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/servlet-api-2.5-6.1.14.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/slf4j-api-1.5.11.jar [findbugs] Aux: /hadoop01/jenkins/jobs/hadoop-hdfs-test/workspace/hdfs/build/ivy/lib/Hadoop-Hdfs/common/xmlenc-0.52.jar [findbugs] Exception in thread "main" java.lang.OutOfMemoryError: GC overhead limit exceeded [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.createFact(TypeAnalysis.java:291) [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.getCachedExceptionSet(TypeAnalysis.java:688) [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.computeThrownExceptionTypes(TypeAnalysis.java:438) [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.transfer(TypeAnalysis.java:410) [findbugs] at edu.umd.cs.findbugs.ba.type.TypeAnalysis.transfer(TypeAnalysis.java:88) [findbugs] at edu.umd.cs.findbugs.ba.Dataflow.execute(Dataflow.java:356) [findbugs] at edu.umd.cs.findbugs.classfile.engine.bcel.TypeDataflowFactory.analyze(TypeDataflowFactory.java:82) ... 27 more [findbugs] Java Result: 1
          Hide
          Konstantin Shvachko added a comment -

          +1 makes sense. Do we need to commit HADOOP-7381 to 0.22?

          Show
          Konstantin Shvachko added a comment - +1 makes sense. Do we need to commit HADOOP-7381 to 0.22?
          Hide
          Konstantin Shvachko added a comment -

          I just committed this. Thank you Joep.

          Show
          Konstantin Shvachko added a comment - I just committed this. Thank you Joep.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #80 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/80/)
          HDFS-2297. ant should pass jvmargs to findbugs. Contributed by Joep Rottinghuis.

          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163893
          Files :

          • /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/hdfs/build.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #80 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/80/ ) HDFS-2297 . ant should pass jvmargs to findbugs. Contributed by Joep Rottinghuis. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163893 Files : /hadoop/common/branches/branch-0.22/hdfs/CHANGES.txt /hadoop/common/branches/branch-0.22/hdfs/build.xml

            People

            • Assignee:
              Joep Rottinghuis
              Reporter:
              Joep Rottinghuis
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development