Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This will also fix a few misc broken tests.

      1. HDFS-1983.patch
        202 kB
        Daryn Sharp
      2. HDFS-1983-2.patch
        202 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/)
          HDFS-1983. Fix path display for copy and rm commands in TestHDFSCLI and TestDFSShell. Contributed by Daryn Sharp.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127712
          Files :

          • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
          • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
          • /hadoop/hdfs/trunk/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/678/ ) HDFS-1983 . Fix path display for copy and rm commands in TestHDFSCLI and TestDFSShell. Contributed by Daryn Sharp. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127712 Files : /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/hdfs/trunk/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #685 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/685/)
          HDFS-1983. Fix path display for copy and rm commands in TestHDFSCLI and TestDFSShell. Contributed by Daryn Sharp.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127712
          Files :

          • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml
          • /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java
          • /hadoop/hdfs/trunk/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #685 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/685/ ) HDFS-1983 . Fix path display for copy and rm commands in TestHDFSCLI and TestDFSShell. Contributed by Daryn Sharp. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127712 Files : /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/cli/testHDFSConf.xml /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSShell.java /hadoop/hdfs/trunk/CHANGES.txt
          Hide
          tlipcon Todd Lipcon added a comment -

          Related passed manually. Committed to trunk, thanks Daryn!

          Show
          tlipcon Todd Lipcon added a comment - Related passed manually. Committed to trunk, thanks Daryn!
          Hide
          tlipcon Todd Lipcon added a comment -

          We should be picking up guava via common, which now depends on it. No big deal, though. +1 on this patch. Unfortunately Hudson seems stalled, but since this is just a test change, I will manually run the modified tests before commit.

          Show
          tlipcon Todd Lipcon added a comment - We should be picking up guava via common, which now depends on it. No big deal, though. +1 on this patch. Unfortunately Hudson seems stalled, but since this is just a test change, I will manually run the modified tests before commit.
          Hide
          daryn Daryn Sharp added a comment -

          Removed the tabs. Time to change my vimrc... We don't appear to currently have a dep on google's common base, so I didn't change to using a Joiner. Let me know if that's not ok.

          Show
          daryn Daryn Sharp added a comment - Removed the tabs. Time to change my vimrc... We don't appear to currently have a dep on google's common base, so I didn't change to using a Joiner. Let me know if that's not ok.
          Hide
          tlipcon Todd Lipcon added a comment -
          • looks like some hard tabs snuck in (in runCmd())
          • can you use Joiner.on(" ").join(args) instead of using the StringBuilder in the same function?

          Otherwise, looks good

          Show
          tlipcon Todd Lipcon added a comment - looks like some hard tabs snuck in (in runCmd()) can you use Joiner.on(" ").join(args) instead of using the StringBuilder in the same function? Otherwise, looks good
          Hide
          daryn Daryn Sharp added a comment -

          Fixes all remaining issues in DFSShell and HDFSCLI tests.

          Show
          daryn Daryn Sharp added a comment - Fixes all remaining issues in DFSShell and HDFSCLI tests.
          Hide
          daryn Daryn Sharp added a comment -

          This will fix the tests that will break when hadoop-7320 is committed.

          Show
          daryn Daryn Sharp added a comment - This will fix the tests that will break when hadoop-7320 is committed.

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development