Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None

      Description

      The FsShell commands are very tightly coupled together which makes it necessarily hard to write new commands. There is a lot of redundancy between the commands, inconsistencies in handling of paths, handling of errors, and correct return of exit codes. The FsShell commands should be subclasses of the fs.shell.Command class which is already being used by the -count command, and is used by other commands like dfsadmin.

      This will serve as an umbrella bug to track the changes.

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          This had already gone in 0.23.0 (per the tag sources). 0.24 is a non-existent version, so changed the Fix Version to point to 0.23.0 where this was apparently already completed.

          Show
          Harsh J added a comment - This had already gone in 0.23.0 (per the tag sources). 0.24 is a non-existent version, so changed the Fix Version to point to 0.23.0 where this was apparently already completed.
          Harsh J made changes -
          Fix Version/s 0.23.0 [ 12315569 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Daryn Sharp made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Resolution Fixed [ 1 ]
          Hide
          Daryn Sharp added a comment -

          These changes were completed long ago. Closing.

          Show
          Daryn Sharp added a comment - These changes were completed long ago. Closing.
          Konstantin Shvachko made changes -
          Fix Version/s 0.22.0 [ 12314296 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7360 [ HADOOP-7360 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7353 [ HADOOP-7353 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7341 [ HADOOP-7341 ]
          Daryn Sharp made changes -
          Link This issue incorporates HDFS-1983 [ HDFS-1983 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7320 [ HADOOP-7320 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7271 [ HADOOP-7271 ]
          Daryn Sharp made changes -
          Link This issue is blocked by HADOOP-7265 [ HADOOP-7265 ]
          Daryn Sharp made changes -
          Link This issue breaks HDFS-1901 [ HDFS-1901 ]
          Hide
          Daryn Sharp added a comment -

          This bug is implicitly fixing bugs in all the commands regarding handling of globs and exit codes of 0 when multiple args and/or globs are supplied and have errors. If anyone has available time, I'd like to please request reviews for the linked bugs. Thanks in advance.

          Show
          Daryn Sharp added a comment - This bug is implicitly fixing bugs in all the commands regarding handling of globs and exit codes of 0 when multiple args and/or globs are supplied and have errors. If anyone has available time, I'd like to please request reviews for the linked bugs. Thanks in advance.
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7251 [ HADOOP-7251 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7250 [ HADOOP-7250 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7249 [ HADOOP-7249 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7238 [ HADOOP-7238 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7237 [ HADOOP-7237 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7236 [ HADOOP-7236 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7235 [ HADOOP-7235 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7233 [ HADOOP-7233 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7224 [ HADOOP-7224 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > What do you mean by offline? Design discussions should be on JIRA.

          Hey Jakob, I seems to recall that you sometimes have design discussions with other people privately. No?

          Show
          Tsz Wo Nicholas Sze added a comment - > What do you mean by offline? Design discussions should be on JIRA. Hey Jakob, I seems to recall that you sometimes have design discussions with other people privately. No?
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7209 [ HADOOP-7209 ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7202 [ HADOOP-7202 ]
          Daryn Sharp made changes -
          Assignee Daryn Sharp [ daryn ]
          Daryn Sharp made changes -
          Link This issue incorporates HADOOP-7180 [ HADOOP-7180 ]
          Hide
          Daryn Sharp added a comment -

          My apologies, we are both yahoos so I figured we could internally discuss and then summarize for approval.

          Show
          Daryn Sharp added a comment - My apologies, we are both yahoos so I figured we could internally discuss and then summarize for approval.
          Hide
          Jakob Homan added a comment -

          What do you mean by offline? Design discussions should be on JIRA.

          Show
          Jakob Homan added a comment - What do you mean by offline? Design discussions should be on JIRA.
          Hide
          Daryn Sharp added a comment -

          Definitively maintaining backwards compatibility. Let's discuss #2 offline.

          Show
          Daryn Sharp added a comment - Definitively maintaining backwards compatibility. Let's discuss #2 offline.
          Jakob Homan made changes -
          Link This issue duplicates HADOOP-6425 [ HADOOP-6425 ]
          Hide
          Olga Natkovich added a comment -

          Pig project uses FsShell to export HDFS commands to the users. Things that are important to us:

          (1) Backward compatibility
          (2) Better error handling. At this point if command fails it seems to always return -1 so we can't tell different problems apart.

          Show
          Olga Natkovich added a comment - Pig project uses FsShell to export HDFS commands to the users. Things that are important to us: (1) Backward compatibility (2) Better error handling. At this point if command fails it seems to always return -1 so we can't tell different problems apart.
          Daryn Sharp made changes -
          Link This issue is blocked by HADOOP-6143 [ HADOOP-6143 ]
          Daryn Sharp made changes -
          Link This issue is blocked by HDFS-1736 [ HDFS-1736 ]
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue is blocked by HADOOP-7175 [ HADOOP-7175 ]
          Daryn Sharp created issue -

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development