Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1939

ivy: test conf should not extend common conf

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      * Removed duplicated jars in test class path.

      Description

      Similar improvement as HADOOP-7289.

      1. HDFS-1939-1.patch
        5 kB
        Eric Yang
      2. HDFS-1939.patch
        2 kB
        Eric Yang

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #665 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/665/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #665 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/665/ )
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Checked the Jenkins build. The compilation works fine.

          I have committed this. Thanks, Eric!

          Show
          Tsz Wo Nicholas Sze added a comment - Checked the Jenkins build. The compilation works fine. I have committed this. Thanks, Eric!
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479497/HDFS-1939-1.patch
          against trunk revision 1104463.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479497/HDFS-1939-1.patch against trunk revision 1104463. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/544//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          It works fine now. Let's wait for Jenkins.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. It works fine now. Let's wait for Jenkins.
          Hide
          Eric Yang added a comment -

          Revised patch to make sure fault-injection test locates hadoop-common jar file from ivy/lib/hadoop-hdfs/common instead of ivy/lib/hadoop-hdfs/test.

          Show
          Eric Yang added a comment - Revised patch to make sure fault-injection test locates hadoop-common jar file from ivy/lib/hadoop-hdfs/common instead of ivy/lib/hadoop-hdfs/test.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I used the following command in this build

          ant test-core -Dtestcase=TestFsPermission
          
          Show
          Tsz Wo Nicholas Sze added a comment - I used the following command in this build ant test-core -Dtestcase=TestFsPermission
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479348/HDFS-1939.patch
          against trunk revision 1103987.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479348/HDFS-1939.patch against trunk revision 1103987. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/532//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The patch failed my build.

          ...
          -compile-fault-inject:
               [echo] Start weaving aspects in place
               [iajc] [warning] build config error: skipping missing, empty or corrupt aspectpath entry:
           /export/crawlspace/tsz/asf/hdfs-commit/build-fi/ivy/lib/hadoop-hdfs/test/hadoop-common-0.23.0-SNAPSHOT.jar
               [iajc] 
               [iajc] 
               [iajc] 1 warning
          
          BUILD FAILED
          /export/crawlspace/tsz/asf/hdfs-commit/build.xml:751: The following error occurred while executing this line:
          /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:146: The following error occurred while executing this line:
          /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:203: The following error occurred while executing this line:
          /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:101: Broken binding of advises: 
               [iajc] [warning] build config error: skipping missing, empty or corrupt aspectpath entry:
           /export/crawlspace/tsz/asf/hdfs-commit/build-fi/ivy/lib/hadoop-hdfs/test/hadoop-common-0.23.0-SNAPSHOT.jar
               [iajc] 1 warning
          
          Total time: 44 seconds
          
          Show
          Tsz Wo Nicholas Sze added a comment - The patch failed my build. ... -compile-fault-inject: [echo] Start weaving aspects in place [iajc] [warning] build config error: skipping missing, empty or corrupt aspectpath entry: /export/crawlspace/tsz/asf/hdfs-commit/build-fi/ivy/lib/hadoop-hdfs/test/hadoop-common-0.23.0-SNAPSHOT.jar [iajc] [iajc] [iajc] 1 warning BUILD FAILED /export/crawlspace/tsz/asf/hdfs-commit/build.xml:751: The following error occurred while executing this line: /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:146: The following error occurred while executing this line: /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:203: The following error occurred while executing this line: /export/crawlspace/tsz/asf/hdfs-commit/src/test/aop/build/aop.xml:101: Broken binding of advises: [iajc] [warning] build config error: skipping missing, empty or corrupt aspectpath entry: /export/crawlspace/tsz/asf/hdfs-commit/build-fi/ivy/lib/hadoop-hdfs/test/hadoop-common-0.23.0-SNAPSHOT.jar [iajc] 1 warning Total time: 44 seconds
          Hide
          Eric Yang added a comment -
          • Fix ivy: test conf to include dependent jar files
          • Use "init" target to initialize test jar file download rather than individual test type.
          Show
          Eric Yang added a comment - Fix ivy: test conf to include dependent jar files Use "init" target to initialize test jar file download rather than individual test type.

            People

            • Assignee:
              Eric Yang
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development