Hadoop Common
  1. Hadoop Common
  2. HADOOP-7289

ivy: test conf should not extend common conf

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Otherwise, the same jars will appear in both build/ivy/lib/Hadoop-Common/common/ and build/ivy/lib/Hadoop-Common/test/.

      1. c7289_20110513.patch
        0.8 kB
        Tsz Wo Nicholas Sze
      2. c7289_20110513b.patch
        2 kB
        Tsz Wo Nicholas Sze
      3. HADOOP-7289.patch
        2 kB
        Eric Yang
      4. HADOOP-7289-1.patch
        2 kB
        Eric Yang

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          c7289_20110513.patch: removed the extension and changed mockito to use test conf.

          Show
          Tsz Wo Nicholas Sze added a comment - c7289_20110513.patch: removed the extension and changed mockito to use test conf.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479154/c7289_20110513.patch
          against trunk revision 1102861.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.http.TestGlobalFilter
          org.apache.hadoop.http.TestHttpServerLifecycle
          org.apache.hadoop.http.TestHttpServerWebapps
          org.apache.hadoop.http.TestHttpServer
          org.apache.hadoop.http.TestServletFilter
          org.apache.hadoop.ipc.TestAvroRpc
          org.apache.hadoop.log.TestLogLevel

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479154/c7289_20110513.patch against trunk revision 1102861. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.http.TestGlobalFilter org.apache.hadoop.http.TestHttpServerLifecycle org.apache.hadoop.http.TestHttpServerWebapps org.apache.hadoop.http.TestHttpServer org.apache.hadoop.http.TestServletFilter org.apache.hadoop.ipc.TestAvroRpc org.apache.hadoop.log.TestLogLevel -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/449//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          +1 looks good.

          Show
          Eric Yang added a comment - +1 looks good.
          Hide
          Todd Lipcon added a comment -

          Looks like those http test case failures might be related to this patch?

          Show
          Todd Lipcon added a comment - Looks like those http test case failures might be related to this patch?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The failed tests require slf4j.

          c7289_20110513b.patch: fixed also slf4j and junit.

          Show
          Tsz Wo Nicholas Sze added a comment - The failed tests require slf4j. c7289_20110513b.patch: fixed also slf4j and junit.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479171/c7289_20110513b.patch
          against trunk revision 1102893.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.metrics2.impl.TestSinkQueue

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479171/c7289_20110513b.patch against trunk revision 1102893. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.metrics2.impl.TestSinkQueue -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/453//console This message is automatically generated.
          Hide
          Eric Yang added a comment -

          Modified Test classpath ordering to include common third party jars first.

          Show
          Eric Yang added a comment - Modified Test classpath ordering to include common third party jars first.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479191/HADOOP-7289.patch
          against trunk revision 1102914.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479191/HADOOP-7289.patch against trunk revision 1102914. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/454//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Eric, if test extends master, then it won't download the jars. Assigning it to you.

          Show
          Tsz Wo Nicholas Sze added a comment - Eric, if test extends master, then it won't download the jars. Assigning it to you.
          Hide
          Eric Yang added a comment -

          Patch for extends test from master.

          Show
          Eric Yang added a comment - Patch for extends test from master.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479199/HADOOP-7289-1.patch
          against trunk revision 1102914.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479199/HADOOP-7289-1.patch against trunk revision 1102914. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/455//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          I have committed this. Thanks, Eric!

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. I have committed this. Thanks, Eric!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #688 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/688/)
          HADOOP-7289. In ivy.xml, test conf should not extend common conf. Contributed by Eric Yang

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #688 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/688/ ) HADOOP-7289 . In ivy.xml, test conf should not extend common conf. Contributed by Eric Yang
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #601 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/601/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #601 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/601/ )

            People

            • Assignee:
              Eric Yang
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development