-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478344/HDFS-1891.part2.patch
against trunk revision 1099972.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.TestDatanodeReport
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/460//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/460//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/460//console
This message is automatically generated.
TestBackupNode failure is due to ipv6 address returned by java Socket.getLocalSocketAddress(). The returned address 0:0:0:0:0:0:0:0:50100.
We need to disable IPV6 by setting system property java.net.preferIPv4Stack to true,
as indicated in http://download.oracle.com/javase/6/docs/technotes/guides/net/ipv6_guide/index.html