Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      IPV6 addresses not handles currently in the common library methods. IPV6 can return address as "0:0:0:0:0:0:port". Some utility methods such as NetUtils#createSocketAddress(), NetUtils#normalizeHostName(), NetUtils#getHostNameOfIp() to name a few, do not handle IPV6 address and expect address to be of format host:port.

      Until IPV6 is formally supported, I propose disabling IPV6 for junit tests to avoid problems seen in HDFS-1891.

      1. HADOOP-7261.1.patch
        1 kB
        Suresh Srinivas
      2. HADOOP-7261.patch
        0.6 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          nidaley Nigel Daley added a comment -

          Should we include this in the contrib build.xml too? Otherwise +1 on the current patch.

          Show
          nidaley Nigel Daley added a comment - Should we include this in the contrib build.xml too? Otherwise +1 on the current patch.
          Hide
          mattf Matt Foley added a comment -

          +1 on this patch

          Show
          mattf Matt Foley added a comment - +1 on this patch
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478337/HADOOP-7261.patch
          against trunk revision 1099633.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478337/HADOOP-7261.patch against trunk revision 1099633. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/410//console This message is automatically generated.
          Hide
          sureshms Suresh Srinivas added a comment -

          Disabled ipv6 for contrib junit tests. I am not planning to run hudson validation for this. Will commit it once I get +1 for the patch.

          Show
          sureshms Suresh Srinivas added a comment - Disabled ipv6 for contrib junit tests. I am not planning to run hudson validation for this. Will commit it once I get +1 for the patch.
          Hide
          mattf Matt Foley added a comment -

          Looks right! Thanks Suresh for doing this, and thanks Nigel for the suggestion.
          +1

          Show
          mattf Matt Foley added a comment - Looks right! Thanks Suresh for doing this, and thanks Nigel for the suggestion. +1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478352/HADOOP-7261.1.patch
          against trunk revision 1099633.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478352/HADOOP-7261.1.patch against trunk revision 1099633. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/411//console This message is automatically generated.
          Hide
          sureshms Suresh Srinivas added a comment -

          I committed the patch.

          Show
          sureshms Suresh Srinivas added a comment - I committed the patch.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #578 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/578/)

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #578 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/578/ )
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/)
          HADOOP-7261. Disable IPV6 for junit tests. Contributed by Suresh Srinivas.

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/ ) HADOOP-7261 . Disable IPV6 for junit tests. Contributed by Suresh Srinivas.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          IPv6 is turned off in the official Hadoop scripts already: HADOOP-6056

          Show
          stevel@apache.org Steve Loughran added a comment - IPv6 is turned off in the official Hadoop scripts already: HADOOP-6056
          Hide
          mattf Matt Foley added a comment -

          Yes, please see further https://issues.apache.org/jira/browse/HDFS-1891?focusedCommentId=13029086&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13029086"

          These fixes are for the junit and contrib junit tests, which are not adequately covered by the modification to hadoop-config.sh done in HADOOP-6056.

          Show
          mattf Matt Foley added a comment - Yes, please see further https://issues.apache.org/jira/browse/HDFS-1891?focusedCommentId=13029086&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13029086 " These fixes are for the junit and contrib junit tests, which are not adequately covered by the modification to hadoop-config.sh done in HADOOP-6056 .

            People

            • Assignee:
              sureshms Suresh Srinivas
              Reporter:
              sureshms Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development