[HDFS-16935] TestFsDatasetImpl.testReportBadBlocks brittle

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.5, 3.3.9
• Fix Version/s: 3.4.0, 3.3.6
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.3.6
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Steve Loughran
• Created: 24/Feb/23 12:24
• Updated: 28/Jan/24 07:15
• Resolved: 01/Mar/23 18:57

Description

jenkins failure as sleep() time not long enough

Failing for the past 1 build (Since #4 )
Took 7.4 sec.
Error Message
expected:<1> but was:<0>
Stacktrace
java.lang.AssertionError: expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)

assert is after a 3s sleep waiting for reports coming in.

      dataNode.reportBadBlocks(block, dataNode.getFSDataset()
          .getFsVolumeReferences().get(0));
      Thread.sleep(3000);                                           // 3s sleep
      BlockManagerTestUtil.updateState(cluster.getNamesystem()
          .getBlockManager());
      // Verify the bad block has been reported to namenode
      Assert.assertEquals(1, cluster.getNamesystem().getCorruptReplicaBlocks());  // here

LambdaTestUtils.eventually() should be used around this assert, maybe with an even shorter initial delay so on faster systems, test is faster.

Issue Links

• Discovered while testing: HADOOP-18470 Release hadoop 3.3.5
• links to: GitHub Pull Request #5432
• links to: https://github.com/apache/hadoop/pull/5432