[HDFS-1611] Some logical issues need to address.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.1, 0.20.2
• Fix Version/s: 0.23.0
• Component/s: hdfs-client, namenode
• Hadoop Flags: Reviewed
• Assignee: Uma Maheswara Rao G
• Reporter: Uma Maheswara Rao G
• Created: 07/Feb/11 14:26
• Updated: 27/Sep/13 06:18
• Resolved: 31/Mar/11 02:31

Description

Title: Some code level logical issues.

Description:

1. DFSClient:
Consider the below case, if we enable only info, then below log will never be logged.
if (ClientDatanodeProtocol.LOG.isDebugEnabled())

{ ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr); }

2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()

catch (NotCompliantMBeanException e)

{ e.printStackTrace(); }

We can avoid using stackTace(). Better to add log message.

Issue Links

• relates to: HADOOP-12428 Fix inconsistency between log-level guards and statements