Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.1, 0.20.2
    • Fix Version/s: 0.23.0
    • Component/s: hdfs-client, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Title: Some code level logical issues.

      Description:

      1. DFSClient:
      Consider the below case, if we enable only info, then below log will never be logged.
      if (ClientDatanodeProtocol.LOG.isDebugEnabled())

      { ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr); }

      2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()

      catch (NotCompliantMBeanException e)

      { e.printStackTrace(); }

      We can avoid using stackTace(). Better to add log message.

      1. HDFS-1611.1.patch
        1 kB
        Uma Maheswara Rao G
      2. HDFS-1611.patch
        1 kB
        Uma Maheswara Rao G

        Issue Links

          Activity

          Uma Maheswara Rao G created issue -
          Uma Maheswara Rao G made changes -
          Field Original Value New Value
          Description Title: Some code level logical issues.

          Description:

          1. DFSClient:
            Consider the below case, if we enable only info, then below log will never be logged.
           if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
                ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
              }

          2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
            
            catch (NotCompliantMBeanException e) {
                e.printStackTrace();
              }

            We can avoid using stackTace(). Better to add log message.

          3. In org.apache.hadoop.hdfs.server.namenode.FSImage
              since SimpleDateFormat is not a thread safe, we can move that to local to the method.
          private static final SimpleDateFormat DATE_FORM =
              new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
          Title: Some code level logical issues.

          Description:

          1. DFSClient:
            Consider the below case, if we enable only info, then below log will never be logged.
           if (ClientDatanodeProtocol.LOG.isDebugEnabled()) {
                ClientDatanodeProtocol.LOG.info("ClientDatanodeProtocol addr=" + addr);
              }

          2.org.apache.hadoop.hdfs.server.namenode.FSNamesystem.registerMBean()
            
            catch (NotCompliantMBeanException e) {
                e.printStackTrace();
              }

            We can avoid using stackTace(). Better to add log message.

          Uma Maheswara Rao G made changes -
          Attachment HDFS-1611.patch [ 12472668 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Verification Result:

          For ths changes tests not required.

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.

          Tests are not required for this changes.That is the reason for -1.

          Show
          Uma Maheswara Rao G added a comment - Verification Result: For ths changes tests not required. [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. Tests are not required for this changes.That is the reason for -1.
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12472668/HDFS-1611.patch
          against trunk revision 1076696.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestFileConcurrentReader

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472668/HDFS-1611.patch against trunk revision 1076696. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/230//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          For the log message for ClientDatanodeProtocol, I think it's better to change the log to Debug level, rather than change the guard. It's not that useful of a log message to be set at INFO level.

          Show
          Todd Lipcon added a comment - For the log message for ClientDatanodeProtocol, I think it's better to change the log to Debug level, rather than change the guard. It's not that useful of a log message to be set at INFO level.
          Todd Lipcon made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Todd Lipcon made changes -
          Assignee Uma Maheswara Rao G [ umamaheswararao ]
          Uma Maheswara Rao G made changes -
          Attachment HDFS-1611.1.patch [ 12472926 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Provide the patch.
          Changed the log level to debug.
          Thank you Todd Lipcon for your comments.

          Show
          Uma Maheswara Rao G added a comment - Provide the patch. Changed the log level to debug. Thank you Todd Lipcon for your comments.
          Uma Maheswara Rao G made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Provided the patch.
          Changed the log level to debug.
          Thank you Todd Lipcon for your comments.

          Show
          Uma Maheswara Rao G added a comment - Provided the patch. Changed the log level to debug. Thank you Todd Lipcon for your comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12472926/HDFS-1611.1.patch
          against trunk revision 1079069.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.datanode.TestBlockReport
          org.apache.hadoop.hdfs.TestFileConcurrentReader

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472926/HDFS-1611.1.patch against trunk revision 1079069. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/240//console This message is automatically generated.
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Todd,
          I fixed the comments, can you please check.

          Show
          Uma Maheswara Rao G added a comment - Hi Todd, I fixed the comments, can you please check.
          Hide
          Todd Lipcon added a comment -

          Committed to trunk. Thanks Uma.

          Show
          Todd Lipcon added a comment - Committed to trunk. Thanks Uma.
          Todd Lipcon made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315571 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/)
          HDFS-1611. Fix up some log messages in DFSClient and MBean registration. Contributed by Uma Maheswara Rao G.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/ ) HDFS-1611 . Fix up some log messages in DFSClient and MBean registration. Contributed by Uma Maheswara Rao G.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Jackie Chang made changes -
          Link This issue relates to HADOOP-9995 [ HADOOP-9995 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          2d 12h 4m 1 Todd Lipcon 07/Mar/11 03:19
          Open Open Patch Available Patch Available
          26d 6h 26m 2 Uma Maheswara Rao G 08/Mar/11 08:57
          Patch Available Patch Available Resolved Resolved
          22d 17h 33m 1 Todd Lipcon 31/Mar/11 02:31

            People

            • Assignee:
              Uma Maheswara Rao G
              Reporter:
              Uma Maheswara Rao G
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development