[HDFS-1572] Checkpointer should trigger checkpoint with specified period.

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.22.0
• Fix Version/s: 0.22.0
• Hadoop Flags: Reviewed
• Assignee: Jakob Homan
• Reporter: Liyin Liang
• Created: 06/Jan/11 12:55
• Updated: 12/Dec/11 06:18
• Resolved: 19/Jan/11 02:38

Description

  long now = now();
  boolean shouldCheckpoint = false;
  if(now >= lastCheckpointTime + periodMSec) {
    shouldCheckpoint = true;
  } else {
    long size = getJournalSize();
    if(size >= checkpointSize)
      shouldCheckpoint = true;
  }

{dfs.namenode.checkpoint.period}

in configuration determines the period of checkpoint. However, with above code, the Checkpointer triggers a checkpoint every 5 minutes (periodMSec=5*60*1000). According to SecondaryNameNode.java, the first if statement should be:

if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
 

Issue Links

• relates to: HADOOP-4539 Streaming Edits to a Backup Node.