Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1572

Checkpointer should trigger checkpoint with specified period.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.22.0
    • 0.22.0
    • None
    • None
    • Reviewed

    Description

        long now = now();
        boolean shouldCheckpoint = false;
        if(now >= lastCheckpointTime + periodMSec) {
          shouldCheckpoint = true;
        } else {
          long size = getJournalSize();
          if(size >= checkpointSize)
            shouldCheckpoint = true;
        }
      
      {dfs.namenode.checkpoint.period}

      in configuration determines the period of checkpoint. However, with above code, the Checkpointer triggers a checkpoint every 5 minutes (periodMSec=5*60*1000). According to SecondaryNameNode.java, the first if statement should be:

      if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
       

      Attachments

        1. 1527-1.diff
          0.6 kB
          Liyin Liang
        2. 1572-2.diff
          3 kB
          Liyin Liang
        3. HDFS-1572.patch
          2 kB
          Jakob Homan
        4. HDFS-1572-2.patch
          2 kB
          Jakob Homan
        5. HDFS-1572-3.patch
          2 kB
          Jakob Homan

        Issue Links

          Activity

            People

              jghoman Jakob Homan
              liangly Liyin Liang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: