Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1555

HDFS 20 append: Disallow pipeline recovery if a file is already being lease recovered

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20-append
    • Fix Version/s: 0.20-append, 0.20.205.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a file is under lease recovery and the writer is still alive, the write pipeline will be killed and then the writer will start a pipeline recovery. Sometimes the pipeline recovery may race before the lease recovery and as a result fail the lease recovery. This is very bad if we want to support the strong recoverLease semantics in HDFS-1554. So it would be nice if we could disallow a file's pipeline recovery while its lease recovery is in progress.

      1. recoveryRace.patch
        4 kB
        Hairong Kuang
      2. HDFS-1555.20-security.1.patch
        6 kB
        Jitendra Nath Pandey
      3. appendRecoveryRace.patch
        6 kB
        Hairong Kuang

        Issue Links

          Activity

          Hide
          Hairong Kuang added a comment -

          Here comes the patch.

          Show
          Hairong Kuang added a comment - Here comes the patch.
          Hide
          Hairong Kuang added a comment -

          Another patch that fixed some bugs in the previous patch.

          Show
          Hairong Kuang added a comment - Another patch that fixed some bugs in the previous patch.
          Hide
          Nicolas Spiegelberg added a comment -

          +1. This is very useful for our HBase use case! Thanks Hairong

          Show
          Nicolas Spiegelberg added a comment - +1. This is very useful for our HBase use case! Thanks Hairong
          Hide
          Hairong Kuang added a comment -

          I just committed this!

          Show
          Hairong Kuang added a comment - I just committed this!
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #1708 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1708/)
          New hadoop version, includes hdfs-1555

          Show
          Hudson added a comment - Integrated in HBase-TRUNK #1708 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1708/ ) New hadoop version, includes hdfs-1555
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for 20-security.

          Show
          Jitendra Nath Pandey added a comment - Patch for 20-security.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. I have committed it to 0.20-security branch.

          Show
          Suresh Srinivas added a comment - +1 for the patch. I have committed it to 0.20-security branch.
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0

            People

            • Assignee:
              Hairong Kuang
              Reporter:
              Hairong Kuang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development