Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1554

Append 0.20: New semantics for recoverLease

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20-append, 0.20.205.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Change recoverLease API to return if the file is closed or not. It also change the semantics of recoverLease to start lease recovery immediately.

      Description

      Current recoverLease API implemented in append 0.20 aims to provide a lighter weight (comparing to using create/append) way to trigger a file's soft lease expiration. From both the use case of hbase and scribe, it could have a stronger semantics: revoking the file's lease, thus starting lease recovery immediately.

      Also I'd like to port this recoverLease API to HDFS 0.22 and trunk since HBase is moving to HDFS 0.22.

      1. HDFS-1554.20-security.1.patch
        15 kB
        Jitendra Nath Pandey
      2. appendRecoverLease1.patch
        14 kB
        Hairong Kuang
      3. appendRecoverLease.patch
        11 kB
        Hairong Kuang

        Issue Links

          Activity

          Hairong Kuang created issue -
          Hairong Kuang made changes -
          Field Original Value New Value
          Link This issue blocks HBASE-2312 [ HBASE-2312 ]
          Nicolas Spiegelberg made changes -
          Link This issue is depended upon by HBASE-2312 [ HBASE-2312 ]
          Hairong Kuang made changes -
          Link This issue is blocked by HDFS-1555 [ HDFS-1555 ]
          Hide
          Hairong Kuang added a comment -

          Here comes the patch for append 0.20.

          Show
          Hairong Kuang added a comment - Here comes the patch for append 0.20.
          Hairong Kuang made changes -
          Attachment appendRecoverLease.patch [ 12467600 ]
          Hairong Kuang made changes -
          Link This issue is related to HDFS-1520 [ HDFS-1520 ]
          Hide
          Hairong Kuang added a comment -

          I also plan to change the recoverLease signature so that it returns if lease recovery is completed or not.

          Show
          Hairong Kuang added a comment - I also plan to change the recoverLease signature so that it returns if lease recovery is completed or not.
          Hide
          Hairong Kuang added a comment -

          appendRecoverLease1.patch supports the newly proposed API change.

          Show
          Hairong Kuang added a comment - appendRecoverLease1.patch supports the newly proposed API change.
          Hairong Kuang made changes -
          Attachment appendRecoverLease1.patch [ 12467769 ]
          Hairong Kuang made changes -
          Attachment appendRecoverLease1.patch [ 12467771 ]
          Hairong Kuang made changes -
          Attachment appendRecoverLease1.patch [ 12467769 ]
          Hide
          Hairong Kuang added a comment -

          Uploaded appendRecoverLease1.patch to review board: https://reviews.apache.org/r/258/.

          Show
          Hairong Kuang added a comment - Uploaded appendRecoverLease1.patch to review board: https://reviews.apache.org/r/258/ .
          Hide
          dhruba borthakur added a comment -

          +1, code looks good.

          Show
          dhruba borthakur added a comment - +1, code looks good.
          Hide
          Hairong Kuang added a comment -

          I've committed this. Thank Dhruba for reviewing the patch.

          Show
          Hairong Kuang added a comment - I've committed this. Thank Dhruba for reviewing the patch.
          Hairong Kuang made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Incompatible change, Reviewed]
          Release Note Change recoverLease API to return if the file is closed or not. It also change the semantics of recoverLease to start lease recovery immediately.
          Resolution Fixed [ 1 ]
          Hide
          Nigel Daley added a comment -

          Hairong, can you please set the Fix Version correctly? Thx.

          Show
          Nigel Daley added a comment - Hairong, can you please set the Fix Version correctly? Thx.
          Hide
          Hairong Kuang added a comment -

          Sorry that I forgot that I meant to introduce this new API to the trunk. Let me change this jira's fix version to append 0.20 and then open a different jira for the trunk.

          Show
          Hairong Kuang added a comment - Sorry that I forgot that I meant to introduce this new API to the trunk. Let me change this jira's fix version to append 0.20 and then open a different jira for the trunk.
          Hairong Kuang made changes -
          Summary New semantics for recoverLease Append 0.20: New semantics for recoverLease
          Fix Version/s 0.22.0 [ 12314241 ]
          Fix Version/s 0.23.0 [ 12315571 ]
          Suresh Srinivas made changes -
          Link This issue is blocked by HDFS-1948 [ HDFS-1948 ]
          Suresh Srinivas made changes -
          Link This issue is blocked by HDFS-1948 [ HDFS-1948 ]
          Suresh Srinivas made changes -
          Link This issue relates to HDFS-1948 [ HDFS-1948 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for 20-security.

          Show
          Jitendra Nath Pandey added a comment - Patch for 20-security.
          Jitendra Nath Pandey made changes -
          Attachment HDFS-1554.20-security.1.patch [ 12492819 ]
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. I committed it to 0.20-security.

          Show
          Suresh Srinivas added a comment - +1 for the patch. I committed it to 0.20-security.
          Suresh Srinivas made changes -
          Fix Version/s 0.20.205.0 [ 12316392 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          18d 19h 50m 1 Hairong Kuang 10/Jan/11 19:03
          Resolved Resolved Closed Closed
          281d 5h 22m 1 Matt Foley 19/Oct/11 01:26

            People

            • Assignee:
              Hairong Kuang
              Reporter:
              Hairong Kuang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development