[HDFS-15095] Fix accidental comment in flaky test TestDecommissioningStatus

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.1.4, 3.2.2
• Component/s: hdfs
• Hadoop Flags: Reviewed
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 06/Jan/20 15:52
• Updated: 10/Jan/20 19:14
• Resolved: 10/Jan/20 18:51

Description

There are some old Jiras suggesting that "testDecommissionStatus" is flaky.

• HDFS-12188
• HDFS-9599
• HDFS-9950
• HDFS-10755

However, HDFS-14854 fix accidentally commented out one of the checks in TestDecommissioningStatus.testDecommissionStatus()". This Jira will restore the commented out code and adds a blocking queue to make the test case deterministic.

My intuition is that monitor task launched by AdminManager may not have enough time to act before we start verifying the status. I suggest the force the main thread to block until the node is added to the blocked node.
 
 

Issue Links

• is caused by: HDFS-14854 Create improved decommission monitor implementation