Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-15095

Fix accidental comment in flaky test TestDecommissioningStatus

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.1.4, 3.2.2
    • Component/s: hdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are some old Jiras suggesting that "testDecommissionStatus" is flaky.

      However, HDFS-14854 fix accidentally commented out one of the checks in TestDecommissioningStatus.testDecommissionStatus()". This Jira will restore the commented out code and adds a blocking queue to make the test case deterministic.

      My intuition is that monitor task launched by AdminManager may not have enough time to act before we start verifying the status. I suggest the force the main thread to block until the node is added to the blocked node.
       
       

        Attachments

        1. HDFS-15095.002.patch
          5 kB
          Ahmed Hussein
        2. HDFS-15095.001.patch
          5 kB
          Ahmed Hussein

          Issue Links

            Activity

              People

              • Assignee:
                ahussein Ahmed Hussein
                Reporter:
                ahussein Ahmed Hussein
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: