Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1466

TestFcHdfsSymlink relies on /tmp/test not existing

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test case testLinkAcrossFileSystems works with files in a directory /tmp/test. On our shared build systems this sometimes breaks because such a directory already exists but owned by some other user. The test case should use the build test dir instead.

        Issue Links

          Activity

          Todd Lipcon created issue -
          Hide
          Todd Lipcon added a comment -

          Same is true of several test cases in TestHDFSFileContextMainOperations

          Show
          Todd Lipcon added a comment - Same is true of several test cases in TestHDFSFileContextMainOperations
          Eli Collins made changes -
          Field Original Value New Value
          Assignee Eli Collins [ eli ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Hide
          Eli Collins added a comment -

          Patch attached. Simple change, I verified by running TestFcHdfsSymlink.

          Show
          Eli Collins added a comment - Patch attached. Simple change, I verified by running TestFcHdfsSymlink.
          Eli Collins made changes -
          Attachment hdfs-1466-1.patch [ 12459545 ]
          Eli Collins made changes -
          Link This issue is blocked by HADOOP-6562 [ HADOOP-6562 ]
          Eli Collins made changes -
          Link This issue blocks HADOOP-6562 [ HADOOP-6562 ]
          Hide
          Todd Lipcon added a comment -

          +1, lgtm, though not sure why the patch adds throws IOException on those getter methods. Fine with me if you just fix that on commit (no need to reupload)

          Show
          Todd Lipcon added a comment - +1, lgtm, though not sure why the patch adds throws IOException on those getter methods. Fine with me if you just fix that on commit (no need to reupload)
          Eli Collins made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Eli Collins added a comment -

          Thanks Todd. The abstract method they override throws IOException since the local fs versions can throw an IOException (they construct a path to create the base directory and that can cause an exception).

          Show
          Eli Collins added a comment - Thanks Todd. The abstract method they override throws IOException since the local fs versions can throw an IOException (they construct a path to create the base directory and that can cause an exception).
          Hide
          Konstantin Boudnik added a comment -

          +1 looks good.

          Show
          Konstantin Boudnik added a comment - +1 looks good.
          Hide
          Eli Collins added a comment -

          Thanks Cos. I committed this.

          Show
          Eli Collins added a comment - Thanks Cos. I committed this.
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          24d 12h 1 Eli Collins 14/Nov/10 07:06
          Patch Available Patch Available Resolved Resolved
          1d 26m 1 Eli Collins 15/Nov/10 07:32

            People

            • Assignee:
              Eli Collins
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development