Hadoop Common
  1. Hadoop Common
  2. HADOOP-6562

FileContextSymlinkBaseTest should use FileContextTestHelper

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FileContextSymlinkBaseTest should use FileContextTestHelper, both for utility methods and defining the root test directory instead of using /tmp.

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached. Modifies FileContextSymlinkBaseTest and TestLocalFSFileContextSymlink to use FileContextTestHelper. The tests now share code and no longer depend on local /tmp.

               [exec] 
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 14 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
               [exec] 
               [exec]     +1 system test framework.  The patch passed system test framework compile.
               [exec] 
          

          The findbugs warning is HADOOP-7033.

          Show
          Eli Collins added a comment - Patch attached. Modifies FileContextSymlinkBaseTest and TestLocalFSFileContextSymlink to use FileContextTestHelper. The tests now share code and no longer depend on local /tmp. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 14 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] The findbugs warning is HADOOP-7033 .
          Hide
          Eli Collins added a comment -

          This patch needs to get checked in with HDFS-1466 since it modifies the signature of an abstract method that a class in HDFS overrides.

          Show
          Eli Collins added a comment - This patch needs to get checked in with HDFS-1466 since it modifies the signature of an abstract method that a class in HDFS overrides.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459544/hadoop-6562-1.patch
          against trunk revision 1034480.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 14 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459544/hadoop-6562-1.patch against trunk revision 1034480. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/101//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Except for a couple white-space changes like

             public static String getAbsoluteTestRootDir(FileContext fc)
          -      throws IOException {
          +  throws IOException {
          

          and

             public static void createFileNonRecursive(FileContext fc, String name)
          -  throws IOException {
          +      throws IOException {
          

          the rest looks good.

          +1 patch looks good conditional to the white-space changes removal. I don't think new patch needs to be re-validated.

          Show
          Konstantin Boudnik added a comment - Except for a couple white-space changes like public static String getAbsoluteTestRootDir(FileContext fc) - throws IOException { + throws IOException { and public static void createFileNonRecursive(FileContext fc, String name) - throws IOException { + throws IOException { the rest looks good. +1 patch looks good conditional to the white-space changes removal. I don't think new patch needs to be re-validated.
          Hide
          Eli Collins added a comment -

          Thanks Cos. I fixed the whitespace issue and committed.

          Show
          Eli Collins added a comment - Thanks Cos. I fixed the whitespace issue and committed.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #425 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/425/)
          HADOOP-6562. FileContextSymlinkBaseTest should use FileContextTestHelper. Contributed by Eli Collins

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #425 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/425/ ) HADOOP-6562 . FileContextSymlinkBaseTest should use FileContextTestHelper. Contributed by Eli Collins
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #514 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/514/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #514 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/514/ )

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development