Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1444

Test related code of build.xml is error-prone and needs to be re-aligned.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.1
    • Fix Version/s: 0.21.1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Test related parts of build.xml introduce at least two places (effectively different) for test classes destination compilation.
      Then some extra logic is applied at say test-jar creation step where the content of one is copied over to another. Etc.

      This seems to be overcomplicated and is better be fixed to prevent possible issues with future build modificaitons.

      1. HDFS-1444.patch
        3 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          Here's the patch which merge two different properties for test classes' locations into one and removes redundant 'copy' logic from the test-jar target.

          All test have passes (except for well-known 6 or 7 failures). Jar files for test classes and their source code are the same before and after this patch's application.

          Show
          Konstantin Boudnik added a comment - Here's the patch which merge two different properties for test classes' locations into one and removes redundant 'copy' logic from the test-jar target. All test have passes (except for well-known 6 or 7 failures). Jar files for test classes and their source code are the same before and after this patch's application.
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Konstantin Boudnik added a comment -

          I have ran test-patch.sh locally:

          +1 overall.  
          
              +1 @author.  The patch does not contain any @author tags.
          
              +1 tests included.  The patch appears to include 1 new or modified tests.
          
              +1 javadoc.  The javadoc tool did not generate any warning messages.
          
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
              +1 findbugs.  The patch does not introduce any new Findbugs warnings.
          
              +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
              +1 system tests framework.  The patch passed system tests framework compile.
          
          Show
          Konstantin Boudnik added a comment - I have ran test-patch.sh locally: +1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system tests framework. The patch passed system tests framework compile.
          Hide
          Konstantin Boudnik added a comment -

          I have committed it to trunk and 0.21.

          Show
          Konstantin Boudnik added a comment - I have committed it to trunk and 0.21.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #408 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/408/)
          HDFS-1444. Test related code of build.xml is error-prone and needs to be re-aligned. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #408 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/408/ ) HDFS-1444 . Test related code of build.xml is error-prone and needs to be re-aligned. Contributed by Konstantin Boudnik.

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development