Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-13999

Bogus missing block warning if the file is under construction when NN starts

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.7.8
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

      We found an interesting case where web UI displays a few missing blocks, but it doesn't state which files are corrupt. What'll also happen is that fsck states the file system is healthy. This bug is similar to HDFS-10827 and HDFS-8533

       (See the attachment for an example)

      Using Dynamometer, I was able to reproduce the bug, and realized the the "missing" blocks are actually healthy, but somehow neededReplications doesn't get updated when NN receives block reports. What's more interesting is that the files associated with the "missing" blocks are under construction when NN starts, and so after a while NN prints file recovery log.

      Given that, I determined the following code is the source of bug:

      BlockManager#addStoredBlock
      ....
         // if file is under construction, then done for now
          if (bc.isUnderConstruction()) {
            return storedBlock;
          }
      

      which is wrong, because a file may have multiple blocks, and the first block is complete. In which case, the neededReplications structure doesn't get updated for the first block, and thus the missing block warning on the web UI. More appropriately, it should check the state of the block itself, not the file.

      Fortunately, it was unintentionally fixed via HDFS-9754:

          // if block is still under construction, then done for now
          if (!storedBlock.isCompleteOrCommitted()) {
            return storedBlock;
          }
      

      We should bring this fix into branch-2.7 too. That said, this is a harmless warning, and should go away after the under-construction-files are recovered, and the NN restarts (or force full block reports).

      Kudos to Dynamometer! It would be impossible to reproduce this bug without the tool. And thanks Siyao Meng for helping with the reproduction.

        Attachments

        1. webui missing blocks.png
          115 kB
          Wei-Chiu Chuang
        2. HDFS-13999.branch-2.7.001.patch
          2 kB
          Wei-Chiu Chuang

          Issue Links

            Activity

              People

              • Assignee:
                jojochuang Wei-Chiu Chuang
                Reporter:
                jojochuang Wei-Chiu Chuang
              • Votes:
                0 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: