Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1355

ant veryclean (clean-cache) doesn't clean enough

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      build ant veryclean

      Description

      Looks like since HDFS-1159, ant veryclean no longer work as expected for the case when hadoop common jars are changed. The proposed patch does a more through cleaning on hadoop jars.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #379 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/379/)
          HDFS-1355. ant veryclean (clean-cache) doesn't clean enough. Contributed by Luke Lu.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #379 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/379/ ) HDFS-1355 . ant veryclean (clean-cache) doesn't clean enough. Contributed by Luke Lu.
          Hide
          Jakob Homan added a comment -

          I've committed this. Resolving as fixed. Thanks, Luke!

          Show
          Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks, Luke!
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Luke Lu added a comment -

          Test patch results. Javadoc warning is unrelated to this change (build.xml only)

          [exec] BUILD SUCCESSFUL
          [exec] Total time: 55 seconds
          [exec]
          [exec]
          [exec]
          [exec]
          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.
          [exec]

          Show
          Luke Lu added a comment - Test patch results. Javadoc warning is unrelated to this change (build.xml only) [exec] BUILD SUCCESSFUL [exec] Total time: 55 seconds [exec] [exec] [exec] [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec]
          Hide
          Luke Lu added a comment -

          Hudson's back. Give it a little nudge.

          Show
          Luke Lu added a comment - Hudson's back. Give it a little nudge.
          Hide
          Konstantin Boudnik added a comment -

          let's make sure it is reflected in the JIRA's deps. then

          Show
          Konstantin Boudnik added a comment - let's make sure it is reflected in the JIRA's deps. then
          Hide
          Luke Lu added a comment -

          Looks like without HDFS-1352, trunk wouldn't build and test patch would fail as well.

          Show
          Luke Lu added a comment - Looks like without HDFS-1352 , trunk wouldn't build and test patch would fail as well.
          Hide
          Konstantin Boudnik added a comment -

          +1 Fair enough. Looks like a right fix. Hudson is shot so please run test-patch on your box and post the results here for as usual validation of the patch. Thanks.

          Show
          Konstantin Boudnik added a comment - +1 Fair enough. Looks like a right fix. Hudson is shot so please run test-patch on your box and post the results here for as usual validation of the patch. Thanks.
          Hide
          Luke Lu added a comment -

          Verified on OS X Leopard and Linux (rhel5).

          Show
          Luke Lu added a comment - Verified on OS X Leopard and Linux (rhel5).

            People

            • Assignee:
              Luke Lu
              Reporter:
              Luke Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development