Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The jsvc specified in build.xml 404s, causing the build to fail, because version 1.0.2 has been archived. Let's update the url, not sure we want to move to 1.0.3 or play the game where the build breaks with every jsvc dot release.

      1. HDFS-1352-y20.patch
        0.6 kB
        Jakob Homan
      2. hdfs-1352-1.patch
        0.7 kB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          Patch attached.

          Show
          Eli Collins added a comment - Patch attached.
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Jakob Homan added a comment -

          Patch for y20. Not for commit. I'd like to stick with 1.0.2, since that's the version we're using in production and have verified it works.

          Show
          Jakob Homan added a comment - Patch for y20. Not for commit. I'd like to stick with 1.0.2, since that's the version we're using in production and have verified it works.
          Hide
          Jakob Homan added a comment -

          Eli, with Hudson missing at sea, can you run test-patch? It should be fine, but we should double check. Tests don't need to be run... After that I'll commit it.

          Show
          Jakob Homan added a comment - Eli, with Hudson missing at sea, can you run test-patch? It should be fine, but we should double check. Tests don't need to be run... After that I'll commit it.
          Hide
          Eli Collins added a comment -

          Hm, looks like there's no test-patch in hdfs, does this need to be modified to use HADOOP_COMMON_HOME?

          hdfs3 (trunk)$ ant-test-patch  temp.patch 
          ...
          test-patch:
               [exec] bash: /home/eli/src/hdfs3/src/test/bin/test-patch.sh: No such file or directory
          
          Show
          Eli Collins added a comment - Hm, looks like there's no test-patch in hdfs, does this need to be modified to use HADOOP_COMMON_HOME? hdfs3 (trunk)$ ant-test-patch temp.patch ... test-patch: [exec] bash: /home/eli/src/hdfs3/src/test/bin/test-patch.sh: No such file or directory
          Hide
          Jakob Homan added a comment -

          HDFS uses svn:externals to fetch the test-patch script from Core, but doesn't support svn:externals. So you either need to run tp from an svn checkout or (what I do) just manually copy the script over to ./src/test/bin/test-patch.sh

          Show
          Jakob Homan added a comment - HDFS uses svn:externals to fetch the test-patch script from Core, but doesn't support svn:externals. So you either need to run tp from an svn checkout or (what I do) just manually copy the script over to ./src/test/bin/test-patch.sh
          Hide
          Jakob Homan added a comment -

          ^but doesn't support^but git doesn't support

          ... sigh.

          Show
          Jakob Homan added a comment - ^but doesn't support^but git doesn't support ... sigh.
          Hide
          Luke Lu added a comment -

          Note, since the build failure is caused by an external change in an external dependency, the test-patch would fail due to trunk build failure.
          +1 for committing this patch, as all other hdfs patches depend on this one.

          Show
          Luke Lu added a comment - Note, since the build failure is caused by an external change in an external dependency, the test-patch would fail due to trunk build failure. +1 for committing this patch, as all other hdfs patches depend on this one.
          Hide
          Jakob Homan added a comment -

          Verified manually. Going to commit.

          Show
          Jakob Homan added a comment - Verified manually. Going to commit.
          Hide
          Jakob Homan added a comment -

          I've committed this. Resolving as fixed. Thanks, Eli. Now that 1.0.2 has been archived, its location won't change again and this shouldn't re-occur.

          Show
          Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks, Eli. Now that 1.0.2 has been archived, its location won't change again and this shouldn't re-occur.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #374 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/374/)
          HDFS-1352. Fix jsvc.location. Contributed by Eli Collins.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #374 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/374/ ) HDFS-1352 . Fix jsvc.location. Contributed by Eli Collins.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development