Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1299

'compile-fault-inject' never should be called directly.

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.21.0
    • 0.21.0
    • build
    • None
    • Reviewed

    Description

      Although target 'compile-fault-inject' isn't listed as a top-level target for the build it is still can be called if a person can lurk into src/test/build/aop.xml file. The target doesn't set all needed environment and never should be called directly.

      Attachments

        1. HDFS-1299.patch
          1 kB
          Konstantin I Boudnik

        Issue Links

          Activity

            hudson Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #341 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/341/)
            HDFS-1299. 'compile-fault-inject' never should be called directly. Contributed by Konstantin Boudnik

            hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #341 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/341/ ) HDFS-1299 . 'compile-fault-inject' never should be called directly. Contributed by Konstantin Boudnik

            I have just committed this.

            cos Konstantin I Boudnik added a comment - I have just committed this.
            eli Eli Collins added a comment -

            +1

            Btw the compile-fault-inject failures I was seeing using ant mvn-install went away, think the apache maven repo was out of date. Thanks, Eli

            eli Eli Collins added a comment - +1 Btw the compile-fault-inject failures I was seeing using ant mvn-install went away, think the apache maven repo was out of date. Thanks, Eli

            All test failures are at least 15 days old and seemingly unrelated to the patch. TestFiHFlush.hFlushFi01_a is a known intermittent issue.

            cos Konstantin I Boudnik added a comment - All test failures are at least 15 days old and seemingly unrelated to the patch. TestFiHFlush.hFlushFi01_a is a known intermittent issue.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12449426/HDFS-1299.patch
            against trunk revision 963908.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 3 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed core unit tests.

            -1 contrib tests. The patch failed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/checkstyle-errors.html
            Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449426/HDFS-1299.patch against trunk revision 963908. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/console This message is automatically generated.

            Off you go.

            cos Konstantin I Boudnik added a comment - Off you go.

            The patch for the issue which guarantees that the target won't be called directly.

            cos Konstantin I Boudnik added a comment - The patch for the issue which guarantees that the target won't be called directly.

            People

              cos Konstantin I Boudnik
              cos Konstantin I Boudnik
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: