Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1299

'compile-fault-inject' never should be called directly.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Although target 'compile-fault-inject' isn't listed as a top-level target for the build it is still can be called if a person can lurk into src/test/build/aop.xml file. The target doesn't set all needed environment and never should be called directly.

      1. HDFS-1299.patch
        1 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4m 31s 1 Konstantin Boudnik 14/Jul/10 07:52
          Patch Available Patch Available Resolved Resolved
          11h 36m 1 Konstantin Boudnik 14/Jul/10 19:28
          Resolved Resolved Closed Closed
          41d 2h 24m 1 Tom White 24/Aug/10 21:52
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #341 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/341/)
          HDFS-1299. 'compile-fault-inject' never should be called directly. Contributed by Konstantin Boudnik

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #341 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/341/ ) HDFS-1299 . 'compile-fault-inject' never should be called directly. Contributed by Konstantin Boudnik
          Konstantin Boudnik made changes -
          Link This issue relates to MAPREDUCE-1942 [ MAPREDUCE-1942 ]
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.0 [ 12314046 ]
          Resolution Fixed [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          I have just committed this.

          Show
          Konstantin Boudnik added a comment - I have just committed this.
          Hide
          Eli Collins added a comment -

          +1

          Btw the compile-fault-inject failures I was seeing using ant mvn-install went away, think the apache maven repo was out of date. Thanks, Eli

          Show
          Eli Collins added a comment - +1 Btw the compile-fault-inject failures I was seeing using ant mvn-install went away, think the apache maven repo was out of date. Thanks, Eli
          Hide
          Konstantin Boudnik added a comment -

          All test failures are at least 15 days old and seemingly unrelated to the patch. TestFiHFlush.hFlushFi01_a is a known intermittent issue.

          Show
          Konstantin Boudnik added a comment - All test failures are at least 15 days old and seemingly unrelated to the patch. TestFiHFlush.hFlushFi01_a is a known intermittent issue.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449426/HDFS-1299.patch
          against trunk revision 963908.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449426/HDFS-1299.patch against trunk revision 963908. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/433/console This message is automatically generated.
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Konstantin Boudnik added a comment -

          Off you go.

          Show
          Konstantin Boudnik added a comment - Off you go.
          Konstantin Boudnik made changes -
          Field Original Value New Value
          Attachment HDFS-1299.patch [ 12449426 ]
          Hide
          Konstantin Boudnik added a comment -

          The patch for the issue which guarantees that the target won't be called directly.

          Show
          Konstantin Boudnik added a comment - The patch for the issue which guarantees that the target won't be called directly.
          Konstantin Boudnik created issue -

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development