Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12963

Error log level in ShortCircuitRegistry#removeShm

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.1.0
    • None
    • None
    • Reviewed

    Description

      org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java
      
        public synchronized void removeShm(ShortCircuitShm shm) {
          if (LOG.isTraceEnabled()) {
              LOG.debug("removing shm " + shm);   ------------------ I think here should be trace
          }
          // Stop tracking the shmId.
          RegisteredShm removedShm = segments.remove(shm.getShmId());
          Preconditions.checkState(removedShm == shm,
              "failed to remove " + shm.getShmId());
          // Stop tracking the slots.
          for (Iterator<Slot> iter = shm.slotIterator(); iter.hasNext(); ) {
            Slot slot = iter.next();
            boolean removed = slots.remove(slot.getBlockId(), slot);
            Preconditions.checkState(removed);
            slot.makeInvalid();
          }
          // De-allocate the memory map and close the shared file. 
          shm.free();
        }
      

      Attachments

        1. HDFS-12963.001.patch
          1 kB
          hu xiaodong

        Activity

          People

            xiaodong.hu hu xiaodong
            xiaodong.hu hu xiaodong
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: