[HDFS-12963] Error log level in ShortCircuitRegistry#removeShm

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Target Version/s: 3.1.0
• Hadoop Flags: Reviewed
• Assignee: hu xiaodong
• Reporter: hu xiaodong
• Created: 25/Dec/17 08:07
• Updated: 24/Jan/18 03:05
• Resolved: 24/Jan/18 02:45

Description

org.apache.hadoop.hdfs.server.datanode.ShortCircuitRegistry.java

  public synchronized void removeShm(ShortCircuitShm shm) {
    if (LOG.isTraceEnabled()) {
        LOG.debug("removing shm " + shm);   ------------------ I think here should be trace
    }
    // Stop tracking the shmId.
    RegisteredShm removedShm = segments.remove(shm.getShmId());
    Preconditions.checkState(removedShm == shm,
        "failed to remove " + shm.getShmId());
    // Stop tracking the slots.
    for (Iterator<Slot> iter = shm.slotIterator(); iter.hasNext(); ) {
      Slot slot = iter.next();
      boolean removed = slots.remove(slot.getBlockId(), slot);
      Preconditions.checkState(removed);
      slot.makeInvalid();
    }
    // De-allocate the memory map and close the shared file. 
    shm.free();
  }