[HDFS-12278] LeaseManager operations are inefficient in 2.8.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2
• Component/s: namenode
• Target Version/s: 3.0.0-beta1, 2.8.2
• Hadoop Flags: Reviewed
• Assignee: Rushabh Shah
• Reporter: Rushabh Shah
• Created: 08/Aug/17 20:44
• Updated: 09/Aug/17 23:11
• Resolved: 09/Aug/17 22:03

Description

After HDFS-6757, LeaseManager #removeLease became expensive.
HDFS-6757 changed the sortedLeases object from TreeSet to PriorityQueue.
Previously the remove(Object) operation from sortedLeases was O(log n) but after the change it became O( n) since it has to find the object first.
Recently we had an incident in one of our production cluster just hours after we upgraded from 2.7 to 2.8
The sortledLeases object had approximately 100,000 items within it.
While removing the lease, it will acquire the LeaseManager lock and that will slow down the lookup of lease also.

HDFS-6757 is a good improvement which replaced the path by inode id.

Issue Links

• is broken by: HDFS-6757 Simplify lease manager with INodeID