Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12278

LeaseManager operations are inefficient in 2.8.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • 2.8.0
    • 2.9.0, 3.0.0-beta1, 2.8.2
    • namenode
    • None

    Description

      After HDFS-6757, LeaseManager #removeLease became expensive.
      HDFS-6757 changed the sortedLeases object from TreeSet to PriorityQueue.
      Previously the remove(Object) operation from sortedLeases was O(log n) but after the change it became O( n) since it has to find the object first.
      Recently we had an incident in one of our production cluster just hours after we upgraded from 2.7 to 2.8
      The sortledLeases object had approximately 100,000 items within it.
      While removing the lease, it will acquire the LeaseManager lock and that will slow down the lookup of lease also.

      HDFS-6757 is a good improvement which replaced the path by inode id.

      Attachments

        1. HDFS-12278-branch-2.8.001.patch
          2 kB
          Rushabh Shah
        2. HDFS-12278.patch
          2 kB
          Rushabh Shah

        Issue Links

          Activity

            People

              shahrs87 Rushabh Shah
              shahrs87 Rushabh Shah
              Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: