[HDFS-1207] 0.20-append: stallReplicationWork should be volatile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.20-append
• Fix Version/s: 0.20-append, 0.20.205.0
• Component/s: namenode
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 16/Jun/10 01:01
• Updated: 19/Oct/11 00:26
• Resolved: 17/Jun/10 01:39

Description

the stallReplicationWork member in FSNamesystem is accessed by multiple threads without synchronization, but isn't marked volatile. I believe this is responsible for about 1% failure rate on TestFileAppend4.testAppendSyncChecksum* on my 8-core test boxes (looking at logs I see replication happening even though we've supposedly disabled it)