Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1207

0.20-append: stallReplicationWork should be volatile

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20-append
    • Fix Version/s: 0.20-append, 0.20.205.0
    • Component/s: namenode
    • Labels:
      None

      Description

      the stallReplicationWork member in FSNamesystem is accessed by multiple threads without synchronization, but isn't marked volatile. I believe this is responsible for about 1% failure rate on TestFileAppend4.testAppendSyncChecksum* on my 8-core test boxes (looking at logs I see replication happening even though we've supposedly disabled it)

      1. hdfs-1207.txt
        1 kB
        Todd Lipcon

        Activity

        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Todd!

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Todd!
        Hide
        Suresh Srinivas added a comment -

        I applied the attached patch to 0.20-security.

        Show
        Suresh Srinivas added a comment - I applied the attached patch to 0.20-security.
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development