Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1187

Modify fetchdt to allow renewing and canceling token

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I would like to extend fetchdt to allow renewing and canceling tokens.

      1. fetchdt.patch
        17 kB
        Owen O'Malley
      2. h1187-14.patch
        20 kB
        Kan Zhang
      3. h1187-15.patch
        20 kB
        Kan Zhang

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          20h 25m 1 Kan Zhang 12/Nov/10 19:18
          Open Open Patch Available Patch Available
          160d 21h 38m 2 Kan Zhang 12/Nov/10 19:18
          Patch Available Patch Available Resolved Resolved
          3d 5h 24m 1 Jakob Homan 16/Nov/10 00:42
          Resolved Resolved Closed Closed
          391d 5h 36m 1 Konstantin Shvachko 12/Dec/11 06:19
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Konstantin Boudnik added a comment -

          I noticed the same set of Fault Inject tests got run 4 times.

          Could you be more specific about there "4 times" ? What tests? Are they executed 4 times again and again? It's not clear.

          Show
          Konstantin Boudnik added a comment - I noticed the same set of Fault Inject tests got run 4 times. Could you be more specific about there "4 times" ? What tests? Are they executed 4 times again and again? It's not clear.
          Jakob Homan made changes -
          Component/s security [ 12313400 ]
          Component/s tools [ 12312944 ]
          Jakob Homan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Resolution Fixed [ 1 ]
          Hide
          Jakob Homan added a comment -

          I've committed this. Resolving as fixed.

          Show
          Jakob Homan added a comment - I've committed this. Resolving as fixed.
          Jakob Homan made changes -
          Hadoop Flags [Reviewed]
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Kan Zhang added a comment -

          Ran "ant test" locally and the following tests failed. But they fail on clean trunk as well and therefore unrelated. I noticed the same set of Fault Inject tests got run 4 times.

          org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.hdfs.TestLargeBlock
          org.apache.hadoop.hdfs.TestPipelines
          org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer

          Test-patch result as follows. The complaint about release audit is not due to this patch.

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or
          modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning
          messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total
          number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs
          warnings.
          [exec]
          [exec] -1 release audit. The applied patch generated 97 release
          audit warnings (more than the trunk's current 1 warnings).
          [exec]
          [exec] +1 system test framework. The patch passed system test
          framework compile.

          Show
          Kan Zhang added a comment - Ran "ant test" locally and the following tests failed. But they fail on clean trunk as well and therefore unrelated. I noticed the same set of Fault Inject tests got run 4 times. org.apache.hadoop.hdfs.server.namenode.TestStorageRestore org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestPipelines org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer Test-patch result as follows. The complaint about release audit is not due to this patch. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 97 release audit warnings (more than the trunk's current 1 warnings). [exec] [exec] +1 system test framework. The patch passed system test framework compile.
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Kan Zhang made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Kan Zhang made changes -
          Attachment h1187-15.patch [ 12459387 ]
          Hide
          Kan Zhang added a comment -

          A new patch to match changes in Common.

          Show
          Kan Zhang added a comment - A new patch to match changes in Common.
          Kan Zhang made changes -
          Attachment h1187-14.patch [ 12459203 ]
          Kan Zhang made changes -
          Attachment h1187-14.patch [ 12459198 ]
          Kan Zhang made changes -
          Link This issue is blocked by HADOOP-7024 [ HADOOP-7024 ]
          Kan Zhang made changes -
          Attachment h1187-14.patch [ 12459198 ]
          Hide
          Kan Zhang added a comment -

          This is a port of Owen's earlier patch to trunk. It additionally adds an option to print a token (show the fields of the token identifier) and to specify the renewer when getting a token.

          Show
          Kan Zhang added a comment - This is a port of Owen's earlier patch to trunk. It additionally adds an option to print a token (show the fields of the token identifier) and to specify the renewer when getting a token.
          Owen O'Malley made changes -
          Field Original Value New Value
          Attachment fetchdt.patch [ 12446313 ]
          Hide
          Owen O'Malley added a comment -

          This patch allows get/renew/cancel of tokens over rpc or http.

          Show
          Owen O'Malley added a comment - This patch allows get/renew/cancel of tokens over rpc or http.
          Owen O'Malley created issue -

            People

            • Assignee:
              Owen O'Malley
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development