Hadoop Common
  1. Hadoop Common
  2. HADOOP-7024

Create a test method for adding file systems during tests.

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It allows a (mocked) filesystem object to be added to cache for testing purposes. This is used by HDFS-1187.

      1. c1178-03.patch
        0.9 kB
        Kan Zhang
      2. c1178-04.patch
        2 kB
        Kan Zhang

        Issue Links

          Activity

          Kan Zhang created issue -
          Kan Zhang made changes -
          Field Original Value New Value
          Attachment c1178-03.patch [ 12459200 ]
          Kan Zhang made changes -
          Link This issue blocks HDFS-1187 [ HDFS-1187 ]
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459200/c1178-03.patch
          against trunk revision 1032730.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459200/c1178-03.patch against trunk revision 1032730. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/83//console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          It's an internal method for unit testing only and will be used by TestDelegationTokenFetcher in HDFS.

          Show
          Kan Zhang added a comment - It's an internal method for unit testing only and will be used by TestDelegationTokenFetcher in HDFS.
          Hide
          Konstantin Boudnik added a comment -

          Would it be more appropriate to have this potentially dangerous method to have a package private visibility and then add a public wrapper in a test utility class?

          Show
          Konstantin Boudnik added a comment - Would it be more appropriate to have this potentially dangerous method to have a package private visibility and then add a public wrapper in a test utility class?
          Hide
          Kan Zhang added a comment -

          Cos, thanks for your suggestion. I'm attaching a new patch to address it. Please review.

          Show
          Kan Zhang added a comment - Cos, thanks for your suggestion. I'm attaching a new patch to address it. Please review.
          Kan Zhang made changes -
          Attachment c1178-04.patch [ 12459385 ]
          Kan Zhang made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459385/c1178-04.patch
          against trunk revision 1033812.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459385/c1178-04.patch against trunk revision 1033812. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/92//console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Great suggestion Cos. +1 on the patch.

          Show
          Jakob Homan added a comment - Great suggestion Cos. +1 on the patch.
          Jakob Homan made changes -
          Hadoop Flags [Reviewed]
          Hide
          Jakob Homan added a comment -

          I've committed this. Resolving as fixed. Thanks, Kan!

          Show
          Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks, Kan!
          Jakob Homan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Assignee Kan Zhang [ kzhang ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Jakob Homan made changes -
          Summary Adding a test method to support the testing of fetchdt tool Create a test method for adding file systems during tests.
          Affects Version/s 0.22.0 [ 12314296 ]
          Component/s test [ 12311440 ]
          Hide
          Konstantin Boudnik added a comment -

          Sorry, missed the comments - patch looks great! Thanks Kan.

          Show
          Konstantin Boudnik added a comment - Sorry, missed the comments - patch looks great! Thanks Kan.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #510 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/510/)
          HADOOP-7024. Create a test method for adding file systems during tests. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #510 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/510/ ) HADOOP-7024 . Create a test method for adding file systems during tests. Contributed by Kan Zhang.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/422/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/422/ )
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          1d 21h 30m 1 Kan Zhang 11/Nov/10 21:35
          Open Open Patch Available Patch Available
          1m 12s 2 Kan Zhang 11/Nov/10 21:35
          Patch Available Patch Available Resolved Resolved
          1h 1 Jakob Homan 11/Nov/10 22:36
          Resolved Resolved Closed Closed
          395d 7h 43m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development