Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are some ASF warnings appeared in branch-2.7 due to test files being created in "hadoop-hdfs/build" instead of 'target' directory. (Similar to HDFS-9571).

      Lines that start with ????? in the ASF License  report indicate files that do not have an Apache license header:
       !????? /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/build/test/data/temp/TestNameNodeMXBean/include
       !????? /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/build/test/data/temp/decommission/include
       !????? /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/build/test/data/temp/decommission/exclude
      

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to branch-2.7. Thanks Yiqun Lin for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7. Thanks Yiqun Lin for the contribution!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1. In 2.8+, GenericTestUtils.getTempPath can be used instead but this issue is in branch-2.7.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1. In 2.8+, GenericTestUtils.getTempPath can be used instead but this issue is in branch-2.7.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 45s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 8m 12s branch-2.7 passed
        +1 compile 0m 58s branch-2.7 passed with JDK v1.8.0_131
        +1 compile 1m 5s branch-2.7 passed with JDK v1.7.0_121
        +1 checkstyle 0m 24s branch-2.7 passed
        +1 mvnsite 0m 59s branch-2.7 passed
        +1 mvneclipse 0m 17s branch-2.7 passed
        +1 findbugs 2m 52s branch-2.7 passed
        +1 javadoc 1m 0s branch-2.7 passed with JDK v1.8.0_131
        +1 javadoc 1m 42s branch-2.7 passed with JDK v1.7.0_121
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 53s the patch passed with JDK v1.8.0_131
        +1 javac 0m 53s the patch passed
        +1 compile 1m 0s the patch passed with JDK v1.7.0_121
        +1 javac 1m 0s the patch passed
        +1 checkstyle 0m 21s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 1s The patch has 1261 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        -1 whitespace 0m 41s The patch 70 line(s) with tabs.
        +1 findbugs 3m 0s the patch passed
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_131
        +1 javadoc 1m 40s the patch passed with JDK v1.7.0_121
        -1 unit 46m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_121.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        139m 7s



        Reason Tests
        JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.web.TestWebHdfsTimeouts
        JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.TestCheckpoint
          hadoop.hdfs.web.TestWebHdfsTimeouts



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:c420dfe
        JIRA Issue HDFS-11795
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867235/HDFS-11795-branch-2.7.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0a1222e78c16 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 2875462
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19372/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19372/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 45s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 12s branch-2.7 passed +1 compile 0m 58s branch-2.7 passed with JDK v1.8.0_131 +1 compile 1m 5s branch-2.7 passed with JDK v1.7.0_121 +1 checkstyle 0m 24s branch-2.7 passed +1 mvnsite 0m 59s branch-2.7 passed +1 mvneclipse 0m 17s branch-2.7 passed +1 findbugs 2m 52s branch-2.7 passed +1 javadoc 1m 0s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 1m 42s branch-2.7 passed with JDK v1.7.0_121 +1 mvninstall 0m 52s the patch passed +1 compile 0m 53s the patch passed with JDK v1.8.0_131 +1 javac 0m 53s the patch passed +1 compile 1m 0s the patch passed with JDK v1.7.0_121 +1 javac 1m 0s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 1s The patch has 1261 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 41s The patch 70 line(s) with tabs. +1 findbugs 3m 0s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 40s the patch passed with JDK v1.7.0_121 -1 unit 46m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 139m 7s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.web.TestWebHdfsTimeouts JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HDFS-11795 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867235/HDFS-11795-branch-2.7.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a1222e78c16 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 2875462 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/19372/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19372/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19372/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a simple fix to get a quick fix.

        Show
        linyiqun Yiqun Lin added a comment - Attach a simple fix to get a quick fix.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development