Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: test
-
Labels:None
-
Hadoop Flags:Reviewed
Description
Every jenkins build report contains 'asflicence warnings' due to test files being created in "hadoop-hdfs/build" instead of 'target' directory.
Fix tests which creates files in "hadoop-hdfs/build" directory.
Issue Links
- is related to
-
HADOOP-12984
Add GenericTestUtils.getTestDir method and use it for temporary directory in tests
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
TestMiniDFSCluster.java and TestHostsFiles.java creates files in "hadoop-hdfs/build" directory,Uploaded the patch ,kindly review..
-1 asflicense 0m 29s Patch generated 2 ASF License warnings.
Fixed the above two warnings which are in TestBlocksWithNotEnoughRacks..Bytheway without this patch there are 57+ warnings..
Steve Loughran, this overlaps somewhat with your HDFS-9263 patch, but I'd like to try to proceed quickly with Brahma's patch here, since it's smaller in scope compared to what you're doing in HDFS-9263. Do you have any objections?
Brahma Reddy Battula, I haven't read the patch yet, but I see there were 2 license warnings remaining in the last Jenkins run. Could you please take a look at fixing those? Thank you!
chris, I've been too busy to finish off '9263, even though its the hadoop branch I'm hooked up.
get this one in first
Steve Loughran, thanks for the go-ahead.
Brahma Reddy Battula, I just noticed that you also posted a 002 patch with a fix for the decom tests, and Jenkins hasn't run on that one yet. I'll keep watching for the results to come back on that one.
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 0s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
| +1 | mvninstall | 8m 4s | trunk passed |
| +1 | compile | 0m 46s | trunk passed with JDK v1.8.0_66 |
| +1 | compile | 0m 44s | trunk passed with JDK v1.7.0_91 |
| +1 | checkstyle | 0m 18s | trunk passed |
| +1 | mvnsite | 0m 56s | trunk passed |
| +1 | mvneclipse | 0m 14s | trunk passed |
| +1 | findbugs | 2m 2s | trunk passed |
| +1 | javadoc | 1m 11s | trunk passed with JDK v1.8.0_66 |
| +1 | javadoc | 1m 58s | trunk passed with JDK v1.7.0_91 |
| +1 | mvninstall | 0m 53s | the patch passed |
| +1 | compile | 0m 45s | the patch passed with JDK v1.8.0_66 |
| +1 | javac | 0m 45s | the patch passed |
| +1 | compile | 0m 44s | the patch passed with JDK v1.7.0_91 |
| +1 | javac | 0m 44s | the patch passed |
| +1 | checkstyle | 0m 17s | the patch passed |
| +1 | mvnsite | 0m 56s | the patch passed |
| +1 | mvneclipse | 0m 15s | the patch passed |
| +1 | whitespace | 0m 0s | Patch has no whitespace issues. |
| +1 | findbugs | 2m 10s | the patch passed |
| +1 | javadoc | 1m 15s | the patch passed with JDK v1.8.0_66 |
| +1 | javadoc | 1m 52s | the patch passed with JDK v1.7.0_91 |
| -1 | unit | 64m 39s | hadoop-hdfs in the patch failed with JDK v1.8.0_66. |
| -1 | unit | 60m 19s | hadoop-hdfs in the patch failed with JDK v1.7.0_91. |
| +1 | asflicense | 0m 30s | Patch does not generate ASF License warnings. |
| 153m 44s |
| Reason | Tests |
|---|---|
| JDK v1.8.0_66 Failed junit tests | hadoop.hdfs.shortcircuit.TestShortCircuitCache |
| hadoop.hdfs.web.TestWebHDFS | |
| hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes | |
| hadoop.hdfs.TestDFSUpgradeFromImage | |
| hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation | |
| hadoop.hdfs.server.datanode.TestBlockScanner | |
| hadoop.hdfs.server.namenode.TestNNThroughputBenchmark | |
| JDK v1.7.0_91 Failed junit tests | hadoop.hdfs.TestDFSUpgradeFromImage |
| hadoop.hdfs.server.blockmanagement.TestBlockManager | |
| hadoop.hdfs.web.TestWebHdfsWithAuthenticationFilter | |
| hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits | |
| hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots | |
| hadoop.hdfs.TestRollingUpgrade | |
| hadoop.hdfs.server.namenode.TestBackupNode | |
| hadoop.hdfs.server.namenode.TestNNThroughputBenchmark | |
| hadoop.hdfs.server.datanode.TestBlockReplacement |
This message was automatically generated.
Thank you Brahma for taking care of this. +1 for pushing this
Jeez, the tests... I went through the typical round of verifying that none of those failures are related to this patch.
+1 for patch v002. I have committed this to trunk, branch-2 and branch-2.8. Brahma, thank you for the patch. Uma, thank you for helping with the review.
FAILURE: Integrated in Hadoop-trunk-Commit #8992 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8992/)
HDFS-9571. Fix ASF Licence warnings in Jenkins reports. Contributed by (cnauroth: rev 6da9deec204a4fa69dfc2d891ce934979d59b0ab)
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHostsFiles.java
- hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlocksWithNotEnoughRacks.java
- hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java
Chris Nauroth thanks for reviewing and committing.And thanks to others for additional reviews.
HDFS-9571This message was automatically generated.