Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11486

Client close() should not fail fast if the last block is being decommissioned

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.9.0, 2.7.4, 3.0.0-alpha4, 2.8.2
    • Component/s: None
    • Labels:
      None

      Description

      If a DFS client closes a file while the last block is being decommissioned, the close() may fail if the decommission of the block does not complete in a few seconds.

      When a DataNode is being decommissioned, NameNode marks the DN's state as DECOMMISSION_INPROGRESS_INPROGRESS, and blocks with replicas on these DataNodes become under-replicated immediately. A close() call which attempts to complete the last open block will fail if the number of live replicas is below minimal replicated factor, due to too many replicas residing on the DataNodes.

      The client internally will try to complete the last open block for up to 5 times by default, which is roughly 12 seconds. After that, close() throws an exception like the following, which is typically not handled properly.

      java.io.IOException: Unable to close file because the last blockBP-33575088-10.0.0.200-1488410554081:blk_1073741827_1003 does not have enough number of replicas.
      
      	at org.apache.hadoop.hdfs.DFSOutputStream.completeFile(DFSOutputStream.java:864)
      	at org.apache.hadoop.hdfs.DFSOutputStream.closeImpl(DFSOutputStream.java:827)
      	at org.apache.hadoop.hdfs.DFSOutputStream.close(DFSOutputStream.java:793)
      	at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.close(FSDataOutputStream.java:72)
      	at org.apache.hadoop.fs.FSDataOutputStream.close(FSDataOutputStream.java:101)
      	at org.apache.hadoop.hdfs.TestDecommission.testCloseWhileDecommission(TestDecommission.java:708)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:498)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
      
      

      Once the exception is thrown, the client usually does not attempt to close again, so the file remains in open state, and the last block remains in under replicated state.

      Subsequently, administrator runs recoverLease tool to salvage the file, but the attempt failed because the block remains in under replicated state. It is not clear why the block is never replicated though. However, administrators think it becomes a corrupt file because the file remains open via fsck -openforwrite and the file modification time is hours ago.

      In summary, I do not think close() should fail because the last block is being decommissioned. The block has sufficient number replicas, and it's just that some replicas are being decommissioned. Decomm should be transparent to clients.

      This issue seems to be more prominent on a very large scale cluster, with min replication factor set to 2.

      1. HDF-11486.test.patch
        2 kB
        Wei-Chiu Chuang
      2. HDFS-11486.001.patch
        7 kB
        Wei-Chiu Chuang
      3. HDFS-11486.002.patch
        2 kB
        Wei-Chiu Chuang
      4. HDFS-11486.003.patch
        3 kB
        Wei-Chiu Chuang
      5. HDFS-11486.test-inmaintenance.patch
        5 kB
        Yiqun Lin
      6. HDFS-11486-branch-2.8.003.patch
        3 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Attach a test that demonstrates this issue.

          This test starts a cluster with 3 nodes, and sets minimal replication factor to 2. It writes a files and intentionally decommissions 2 datanodes. Because the cluster has just 3 nodes, the open file will have less than minmal replication factor number of live replicas. After a few seconds, the test fails with "Unable to close file" error.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Attach a test that demonstrates this issue. This test starts a cluster with 3 nodes, and sets minimal replication factor to 2. It writes a files and intentionally decommissions 2 datanodes. Because the cluster has just 3 nodes, the open file will have less than minmal replication factor number of live replicas. After a few seconds, the test fails with "Unable to close file" error.
          Hide
          jojochuang Wei-Chiu Chuang added a comment - - edited

          There are several fixes to this problem.

          • the client close() can retry close more times and wait until the block meets min replication factor, or
          • the NameNode may return success when the number of live replicas plus number of decommissioned replicas is above min replication factor, and prioritize block replication,
          • or decommission manager should never let a block to become below than min replication factor.
          Show
          jojochuang Wei-Chiu Chuang added a comment - - edited There are several fixes to this problem. the client close() can retry close more times and wait until the block meets min replication factor, or the NameNode may return success when the number of live replicas plus number of decommissioned replicas is above min replication factor, and prioritize block replication, or decommission manager should never let a block to become below than min replication factor.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for investigating this Wei-Chiu,

          I think this is an issue with the NN's completeFile handling. The hasMinStorage check for LIVE nodes excludes D_I_P nodes. This case doesn't come up often since min rep is normally set to 1, and operators typically decommission a rack at a time so there'll always be one replica that's not on a D_I_P node.

          IMO it's still safe to commit/complete a block even when on a D_I_P node. The DecommissionManager does a final block scan before transitioning a node from D_I_P to Decommissioned, which will catch any under-replicated blocks like this. It'd be even better though to add these under-replicated blocks to the replication queues at close time.

          This might also apply to maintenance mode nodes, though I haven't caught up on that work.

          Show
          andrew.wang Andrew Wang added a comment - Thanks for investigating this Wei-Chiu, I think this is an issue with the NN's completeFile handling. The hasMinStorage check for LIVE nodes excludes D_I_P nodes. This case doesn't come up often since min rep is normally set to 1, and operators typically decommission a rack at a time so there'll always be one replica that's not on a D_I_P node. IMO it's still safe to commit/complete a block even when on a D_I_P node. The DecommissionManager does a final block scan before transitioning a node from D_I_P to Decommissioned, which will catch any under-replicated blocks like this. It'd be even better though to add these under-replicated blocks to the replication queues at close time. This might also apply to maintenance mode nodes, though I haven't caught up on that work.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          I guess the issue might also apply to maintenance mode operations, but I do not have insights into it.
          Manoj Govindassamy or Ming Ma would you be able to comment on this? Want to converge on a good fix.

          Thanks!

          Show
          jojochuang Wei-Chiu Chuang added a comment - I guess the issue might also apply to maintenance mode operations, but I do not have insights into it. Manoj Govindassamy or Ming Ma would you be able to comment on this? Want to converge on a good fix. Thanks!
          Hide
          linyiqun Yiqun Lin added a comment -

          It's a nice finding, Wei-Chiu Chuang!

          I guess the issue might also apply to maintenance mode operations,

          I'm sure this also apply to maintenance mode nodes. I have created a test for testing the case that nodes are in maintenance state. Then the file can't be closed as well. As Andrew Wang mentioned, hasMinStorage check for LIVE nodes will excludes D_I_P nodes, and also will excludes in-maintenance state nodes.

          Attached my test patch specified for maintenance mode.

          Show
          linyiqun Yiqun Lin added a comment - It's a nice finding, Wei-Chiu Chuang ! I guess the issue might also apply to maintenance mode operations, I'm sure this also apply to maintenance mode nodes. I have created a test for testing the case that nodes are in maintenance state. Then the file can't be closed as well. As Andrew Wang mentioned, hasMinStorage check for LIVE nodes will excludes D_I_P nodes, and also will excludes in-maintenance state nodes. Attached my test patch specified for maintenance mode.
          Hide
          jojochuang Wei-Chiu Chuang added a comment - - edited

          FYI HDFS-11499 is a similar issue where decommissioning stuck due to incomplete blocks.
          My test passed after I applied the patch from HDFS-11499.

          Show
          jojochuang Wei-Chiu Chuang added a comment - - edited FYI HDFS-11499 is a similar issue where decommissioning stuck due to incomplete blocks. My test passed after I applied the patch from HDFS-11499 .
          Hide
          andrew.wang Andrew Wang added a comment -

          The patch on HDFS-11499 is basically what I was expecting. Would be good to combine it with Yiqun's maintenance test, and an appropriate fix. We can credit everyone in the commit message.

          Show
          andrew.wang Andrew Wang added a comment - The patch on HDFS-11499 is basically what I was expecting. Would be good to combine it with Yiqun's maintenance test, and an appropriate fix. We can credit everyone in the commit message.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Mark this as a dup of HDFS-11499.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Mark this as a dup of HDFS-11499 .
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The fix in HDFS-11499 also fixes this same bug. So close it as a dup.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The fix in HDFS-11499 also fixes this same bug. So close it as a dup.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Wei-Chiu Chuang, Yiqun Lin Could you verify the issue here is resolved by committed HDFS-11499? I think putting additional tests in here would be good.

          Show
          iwasakims Masatake Iwasaki added a comment - Wei-Chiu Chuang , Yiqun Lin Could you verify the issue here is resolved by committed HDFS-11499 ? I think putting additional tests in here would be good.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Good idea Masatake Iwasaki.
          Reopened this jira and attach a new patch that includes both my test and Yiqun Lin's test.

          I verified both tests passed after HDFS-11499 and both failed if I revert HDFS-11499. Updated Yiqun's test slightly to reuse existing test API and objects.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Good idea Masatake Iwasaki . Reopened this jira and attach a new patch that includes both my test and Yiqun Lin 's test. I verified both tests passed after HDFS-11499 and both failed if I revert HDFS-11499 . Updated Yiqun's test slightly to reuse existing test API and objects.
          Hide
          manojg Manoj Govindassamy added a comment - - edited

          Wei-Chiu Chuang, the decommission file close test you wrote (the first patch attached in this jira), should be passing now. The commit in HDFS-11499 covers both Maintenance and Decommission scenarios, but the test i added for file close only covers maintenance state and subsumes Yiqun Lin test. The other decommission test in HDFS-11499 was more for pipeline recovery during decommissioning. So, your decommissioning file close test can be committed as part of this jira.

          Show
          manojg Manoj Govindassamy added a comment - - edited Wei-Chiu Chuang , the decommission file close test you wrote (the first patch attached in this jira), should be passing now. The commit in HDFS-11499 covers both Maintenance and Decommission scenarios, but the test i added for file close only covers maintenance state and subsumes Yiqun Lin test. The other decommission test in HDFS-11499 was more for pipeline recovery during decommissioning. So, your decommissioning file close test can be committed as part of this jira.
          Hide
          manojg Manoj Govindassamy added a comment -

          Wei-Chiu Chuang,
          Thanks for working on this. +1(unbinding) pending my following comment.
          As part of the fix for HDFS-11499, TestMaintenanceState#testFileCloseAfterEnteringMaintenance unit test has been added to cover file close case for maintenance state and it was based on the patch given by Yiqun Lin (credit is due and can be part of this jira commit). So, testClosingFileInMaintenance in your attached patch would be redundant and can be removed. Please let me know if I got this wrong.

          Show
          manojg Manoj Govindassamy added a comment - Wei-Chiu Chuang , Thanks for working on this. +1(unbinding) pending my following comment. As part of the fix for HDFS-11499 , TestMaintenanceState#testFileCloseAfterEnteringMaintenance unit test has been added to cover file close case for maintenance state and it was based on the patch given by Yiqun Lin (credit is due and can be part of this jira commit). So, testClosingFileInMaintenance in your attached patch would be redundant and can be removed. Please let me know if I got this wrong.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for the review, Manoj Govindassamy.
          Here's my patch without the TestMaintenanceState test.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for the review, Manoj Govindassamy . Here's my patch without the TestMaintenanceState test.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 36s trunk passed
          +1 compile 0m 53s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 52s trunk passed
          +1 javadoc 0m 43s trunk passed
          +1 mvninstall 0m 58s the patch passed
          +1 compile 0m 50s the patch passed
          +1 javac 0m 50s the patch passed
          -0 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 107m 31s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          134m 57s



          Reason Tests
          Failed junit tests hadoop.hdfs.qjournal.client.TestQuorumJournalManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11486
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857087/HDFS-11486.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f078acb32f57 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 822a74f
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18666/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18666/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18666/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18666/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 36s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 0m 43s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed -0 checkstyle 0m 36s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30) +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 107m 31s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 134m 57s Reason Tests Failed junit tests hadoop.hdfs.qjournal.client.TestQuorumJournalManager Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11486 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12857087/HDFS-11486.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f078acb32f57 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 822a74f Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18666/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18666/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18666/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18666/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the update, Wei-Chiu Chuang.

          738	    // the close() fails because the last block can not reach minimal
          739	    // replication factor of 2.
          740	    fdos.close();
          

          The comment should describe current expectation close() should succeed.

          It would be better to assert that datanodes remain in DECOMMISSION_INPROGRESS state after closing the file since there is no place to move replicas. It could be done by BlockManagerTestUtil.recheckDecommissionState and assertTrackedAndPending as testPendingNodes do.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the update, Wei-Chiu Chuang . 738 // the close() fails because the last block can not reach minimal 739 // replication factor of 2. 740 fdos.close(); The comment should describe current expectation close() should succeed. It would be better to assert that datanodes remain in DECOMMISSION_INPROGRESS state after closing the file since there is no place to move replicas. It could be done by BlockManagerTestUtil.recheckDecommissionState and assertTrackedAndPending as testPendingNodes do.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hello Masatake Iwasaki thanks for your comments. Sorry it took long to get back to this patch.
          Uploaded v03 patch to address your comment.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hello Masatake Iwasaki thanks for your comments. Sorry it took long to get back to this patch. Uploaded v03 patch to address your comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 13m 14s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 42s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 47s the patch passed
          +1 javac 0m 47s the patch passed
          +1 checkstyle 0m 32s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 54s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 67m 12s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          92m 55s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-11486
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860699/HDFS-11486.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4025590d67ab 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / db2adf3
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18850/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18850/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18850/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 14s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 35s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 32s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 67m 12s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 92m 55s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-11486 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860699/HDFS-11486.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4025590d67ab 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / db2adf3 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18850/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18850/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18850/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the update, Wei-Chiu Chuang. +1, committing this.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the update, Wei-Chiu Chuang . +1, committing this.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11476 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11476/)
          HDFS-11486. Client close() should not fail fast if the last block is (iwasakims: rev 64ea62c1ccc05d9b0a0030beafa60ddd31c38952)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11476 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11476/ ) HDFS-11486 . Client close() should not fail fast if the last block is (iwasakims: rev 64ea62c1ccc05d9b0a0030beafa60ddd31c38952) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          attaching backport patch for QA build on branch-2.8.

          Show
          iwasakims Masatake Iwasaki added a comment - attaching backport patch for QA build on branch-2.8.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 11s branch-2.8 passed
          +1 compile 0m 49s branch-2.8 passed with JDK v1.8.0_121
          +1 compile 0m 45s branch-2.8 passed with JDK v1.7.0_121
          +1 checkstyle 0m 20s branch-2.8 passed
          +1 mvnsite 0m 55s branch-2.8 passed
          +1 mvneclipse 0m 16s branch-2.8 passed
          +1 findbugs 2m 1s branch-2.8 passed
          +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121
          +1 javadoc 1m 33s branch-2.8 passed with JDK v1.7.0_121
          +1 mvninstall 0m 43s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.8.0_121
          +1 javac 0m 38s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_121
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_121
          +1 javadoc 1m 30s the patch passed with JDK v1.7.0_121
          +1 unit 46m 46s hadoop-hdfs in the patch passed with JDK v1.7.0_121.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          123m 12s



          Reason Tests
          JDK v1.8.0_121 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
            hadoop.hdfs.server.namenode.TestCheckpoint



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Issue HDFS-11486
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860783/HDFS-11486-branch-2.8.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1f2c980adf74 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / b218676
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18862/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18862/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 11s branch-2.8 passed +1 compile 0m 49s branch-2.8 passed with JDK v1.8.0_121 +1 compile 0m 45s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 20s branch-2.8 passed +1 mvnsite 0m 55s branch-2.8 passed +1 mvneclipse 0m 16s branch-2.8 passed +1 findbugs 2m 1s branch-2.8 passed +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_121 +1 javadoc 1m 33s branch-2.8 passed with JDK v1.7.0_121 +1 mvninstall 0m 43s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_121 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_121 +1 javac 0m 39s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_121 +1 javadoc 1m 30s the patch passed with JDK v1.7.0_121 +1 unit 46m 46s hadoop-hdfs in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 123m 12s Reason Tests JDK v1.8.0_121 Failed junit tests hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.TestCheckpoint Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue HDFS-11486 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860783/HDFS-11486-branch-2.8.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1f2c980adf74 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / b218676 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18862/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18862/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed this. Thanks, Wei-Chiu Chuang and Yiqun Lin.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed this. Thanks, Wei-Chiu Chuang and Yiqun Lin .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development