Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None

      Description

      HDFS-8826 added an option -source to specify the source node list so that balancer only selects blocks to move from those nodes. This is very efficient in some cases. It also added a new test, testMinBlockSizeAndSourceNodes.

      However, testMinBlockSizeAndSourceNodes does not test -source option parsing, for both valid and invalid cases. It builds the parameters directly instead of parsing them from CLI. This JIRA is to track the effort of changing the test for that. In fact, we can refactor the existing code by replacing code that manually creates BalancerParameters with new code that explores the Balancer$Cli#parse().

      Thanks Jing Zhao for the initial proposal.

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          Tsz Wo Nicholas Sze Could you kindly review? Thanks.

          Show
          liuml07 Mingliang Liu added a comment - Tsz Wo Nicholas Sze Could you kindly review? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 16s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 53s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 42s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 46s the patch passed
          +1 javac 0m 46s the patch passed
          -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 75m 21s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          96m 54s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.datanode.TestFsDatasetCache
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11008
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833261/HDFS-11008.000.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 09d388cb5f21 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a85d07
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17146/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17146/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17146/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17146/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 16s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 42s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed -0 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 206 unchanged - 0 fixed = 207 total (was 206) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 75m 21s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 96m 54s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11008 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833261/HDFS-11008.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 09d388cb5f21 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a85d07 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17146/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17146/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17146/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17146/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          liuml07 Mingliang Liu added a comment -

          Testing failures are not related.

          Show
          liuml07 Mingliang Liu added a comment - Testing failures are not related.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good. Thanks a lot!

          (Revised summary and description.)

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 patch looks good. Thanks a lot! (Revised summary and description.)
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thanks for the patch Mingliang Liu. You might want to fix the check style issue, otherwise, LGTM +1.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thanks for the patch Mingliang Liu . You might want to fix the check style issue, otherwise, LGTM +1.
          Hide
          liuml07 Mingliang Liu added a comment -

          I have committed to trunk through branch-2.8 after fixed the trivial whitespace checkstyle warning. Thanks Tsz Wo Nicholas Sze and Xiaobing Zhou for review (and revising JIRA info).

          Show
          liuml07 Mingliang Liu added a comment - I have committed to trunk through branch-2.8 after fixed the trivial whitespace checkstyle warning. Thanks Tsz Wo Nicholas Sze and Xiaobing Zhou for review (and revising JIRA info).
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10617 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10617/)
          HDFS-11008. Change unit test for testing parsing "-source" parameter in (liuml07: rev 76cc84e6d41c2b02218c2c98d60481cd565e067c)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10617 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10617/ ) HDFS-11008 . Change unit test for testing parsing "-source" parameter in (liuml07: rev 76cc84e6d41c2b02218c2c98d60481cd565e067c) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development