[HDFS-11008] Change unit test for testing parsing "-source" parameter in Balancer CLI

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha2
• Component/s: test
• Target Version/s: 2.8.0, 3.0.0-alpha2
• Hadoop Flags: Reviewed
• Assignee: Mingliang Liu
• Reporter: Mingliang Liu
• Created: 14/Oct/16 00:51
• Updated: 14/Oct/16 22:00
• Resolved: 14/Oct/16 21:45

Description

HDFS-8826 added an option -source to specify the source node list so that balancer only selects blocks to move from those nodes. This is very efficient in some cases. It also added a new test, testMinBlockSizeAndSourceNodes.

However, testMinBlockSizeAndSourceNodes does not test -source option parsing, for both valid and invalid cases. It builds the parameters directly instead of parsing them from CLI. This JIRA is to track the effort of changing the test for that. In fact, we can refactor the existing code by replacing code that manually creates BalancerParameters with new code that explores the Balancer$Cli#parse().

Thanks jingzhao for the initial proposal.

Issue Links

• relates to: HDFS-8826 Balancer may not move blocks efficiently in some cases