Thanks Arpit Agarwal for the review. Update patch to address the feedback.
Why do we have volumeName.replace(':', '-') in DataNodeVolumeMetrics#create? Is it because the : character is not accepted as part of the metric name?
Yes. : is not allowed for metric name. That transformation is just to be safe.
I'm also looking into one of the test failures which seems related.