Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11281

The metric of fileIoErrorRate not counted in DataNodeVolumeMetrics

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0-alpha2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      After HDFS-10959, it added disk IO statistics and metrics in DataNode. This metrics was defined in DataNodeVolumeMetrics. But the metric of fileIoErrorRate was not counted in DataNodeVolumeMetrics. The relevant codes:

        public void addFileIoError(final long latency) {
          totalFileIoErrors.incr();
          metadataOperationRate.add(latency);
        }
      

      Here the metric metadataOperationRate should be fileIoErrorRate. Two reasons: 1.metadataOperationRate has been counted in addMetadastaOperationLatency. 2.fileIoErrorRate is never counted in the class DataNodeVolumeMetrics.

        Attachments

        1. HDFS-11281.001.patch
          0.8 kB
          Yiqun Lin

          Issue Links

            Activity

              People

              • Assignee:
                linyiqun Yiqun Lin
                Reporter:
                linyiqun Yiqun Lin
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: